Skip to content

Von Mises Distribution #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mborland wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Von Mises Distribution #818

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
18a8718
Von Mises Distribution
mborland Aug 15, 2022
9f3626a
Fix formatting issues
mborland Aug 16, 2022
51171c1
Begin re-writing cdf_impl
mborland Aug 18, 2022
2149eeb
Remove double precision constants from CDF impl
mborland Aug 24, 2022
aad56c9
Add documentation
mborland Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Von Mises Distribution
  • Loading branch information
@mborland
mborland committed Aug 15, 2022
commit 18a871853a513ac236912b7c6d92d0c1fb4d981c
22 changes: 22 additions & 0 deletions include/boost/math/distributions/detail/common_error_handling.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

#include <boost/math/policies/error_handling.hpp>
#include <boost/math/special_functions/fpclassify.hpp>
#include <boost/math/constants/constants.hpp>

// using boost::math::isfinite;
// using boost::math::isnan;

Expand Down Expand Up @@ -96,6 +98,26 @@ inline bool check_location(
return true;
}


template <class RealType, class Policy>
inline bool check_angle(
const char* function,
RealType angle,
RealType* result,
const Policy& pol)
{
if(!(boost::math::isfinite)(angle)
|| angle < -boost::math::constants::pi<RealType>()
|| angle > +boost::math::constants::pi<RealType>())
{
*result = policies::raise_domain_error<RealType>(
function,
"Angle parameter is %1%, but must be between -pi and +pi!", angle, pol);
Copy link
Collaborator

@NAThompson NAThompson Aug 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the CDF is periodic, is it sensible to restrict the angle like this?

return false;
}
return true;
}

template <class RealType, class Policy>
inline bool check_x(
const char* function,
Expand Down
6 changes: 5 additions & 1 deletion include/boost/math/distributions/fwd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ class uniform_distribution;
template <class RealType, class Policy>
class weibull_distribution;

template <class RealType, class Policy>
class von_mises_distribution;

}} // namespaces

#define BOOST_MATH_DECLARE_DISTRIBUTIONS(Type, Policy)\
Expand Down Expand Up @@ -152,6 +155,7 @@ class weibull_distribution;
typedef boost::math::students_t_distribution<Type, Policy> students_t;\
typedef boost::math::triangular_distribution<Type, Policy> triangular;\
typedef boost::math::uniform_distribution<Type, Policy> uniform;\
typedef boost::math::weibull_distribution<Type, Policy> weibull;
typedef boost::math::weibull_distribution<Type, Policy> weibull; \
typedef boost::math::von_mises_distribution<Type, Policy> von_mises;

#endif // BOOST_MATH_DISTRIBUTIONS_FWD_HPP
Loading