Skip to content

Conversation

@jzmaddock
Copy link
Collaborator

!!REVERT THIS COMMIT BEFORE MERGE!!

!!REVERT THIS COMMIT BEFORE MERGE!!
@mborland
Copy link
Member

I'm surprised this is green without any corrections

@jzmaddock
Copy link
Collaborator Author

@mborland : Me too! But I'm not particularly unhappy about it :) There were a heck of a lot of fixes in s390x testing though which seems to have done the trick. Testing a full run now....

@mborland
Copy link
Member

Looking at the drone build logs I think we need to revisit how much we are testing with these emulated architectures. Our median build time prior to merging s390x was 46 minutes. Our recent tests have been taking between 5-15 hours because the number of runners for s390x is limited. I recommend we test these like the sanitizers; pick one language standard (C++17) and that is it. We shouldn't need to test __float128 using GNU extensions on s390x because long double is 128-bits, and ARM does not support libquadmath.

@jzmaddock
Copy link
Collaborator Author

All good thoughts, once this is green I'll cut down the permutations.

@jzmaddock
Copy link
Collaborator Author

Failures are spurious, merging.

@jzmaddock jzmaddock merged commit ced477c into develop Jan 14, 2023
@NAThompson NAThompson deleted the arm64 branch January 24, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants