Skip to content

Fix for Scipy Issue 16079 #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mborland wants to merge 10 commits into from
Closed

Fix for Scipy Issue 16079 #925

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
be44110
Hypergeom Slowdown
mborland Jan 23, 2023
7916338
Make all table static const c-arrays instead of constexpr
mborland Jan 23, 2023
3fab04f
Use helper structs to keep constexpr functionality
mborland Jan 24, 2023
2815dfe
Fix for C++14 ODR violations
mborland Jan 24, 2023
0db751c
Fix reverse issue with MSVC
mborland Jan 24, 2023
4efd55a
Artificially make helper structs templates
mborland Jan 24, 2023
ac684a3
Use bounded arrays and cleaner templates
mborland Jan 24, 2023
aa209ac
Tighten definition of when to use declarations
mborland Jan 24, 2023
7770ab1
Use C++03 workaround
mborland Jan 25, 2023
8604582
Fix tables
mborland Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix reverse issue with MSVC
  • Loading branch information
@mborland
mborland committed Jan 24, 2023
commit 0db751c733180449036cbb2a40ac2c26b63dd242
3 changes: 2 additions & 1 deletion include/boost/math/special_functions/prime.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,7 +1193,8 @@ namespace boost{ namespace math{
};

// ODR issues were fixed in C++17 where static constexpr members are now implicity inlined
#if !(defined(__cpp_inline_variables) && __cpp_inline_variables >= 201606L)
// MSVC doesn't like this workaround but has no linker issues to start with
#if !(defined(__cpp_inline_variables) && __cpp_inline_variables >= 201606L) && !defined(_MSVC_LANG)
constexpr unsigned char a1_helper::a1[];
constexpr std::uint16_t a2_helper::a2[];
constexpr std::uint16_t a3_helper::a3[];
Expand Down