Skip to content

simple_continued_fraction: added public functions to access and modify the coefficients #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tomaqa wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

simple_continued_fraction: added public functions to access and modify the coefficients #971

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08f0490
Add free function for calculation of simple continued fraction coeffs
mborland Apr 4, 2023
b547ac7
Update docs
mborland Apr 4, 2023
1f3a079
Fix casting for MSVC
mborland Apr 4, 2023
d83bd53
Typedef for Z `int_type`; replaced member variable `x_` with `precisi…
Apr 11, 2023
25ab7c5
Implemented `simple_continued_fraction(std::vector<Z>)`
Apr 11, 2023
c4c4592
Implemented templated free function `Rational to_rational(simple_cont…
Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix casting for MSVC
  • Loading branch information
@mborland
mborland committed Apr 4, 2023
commit 1f3a079945476fbf57e9548c03e58ad120ccecc0
7 changes: 3 additions & 4 deletions test/simple_continued_fraction_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,9 @@ void test_git_issue_970()
}

// Result is [3; 7, 16]
CHECK_EQUAL(coefs.size(), 3UL);
CHECK_EQUAL(coefs[0], INT64_C(3));
CHECK_EQUAL(coefs[1], INT64_C(7));
CHECK_EQUAL(coefs[2], INT64_C(16));
CHECK_EQUAL(coefs[0], static_cast<std::int64_t>(3));
CHECK_EQUAL(coefs[1], static_cast<std::int64_t>(7));
CHECK_EQUAL(coefs[2], static_cast<std::int64_t>(16));
}

int main()
Expand Down