median_absolute_deviation bug fix for non-zero center #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests for median_absolute_deviation with center=median.
Fix bug causing median_absolute_deviation to return incorrect values when a non-zero center (such as median which is the default) was used.
mborland
approved these changes
Jun 16, 2023
Member
mborland
left a comment
mborland
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this. I approved the CI run; you can ignore the CircleCI failure.
Collaborator
|
@rasmushenningsson : Sincerest thanks for fixing this-at this point I shouldn't be surprised by the sheer stupidity of the mistakes I make . . . but for this was I was! |
Contributor
Author
|
We all make mistakes. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
median_absolute_deviationcausing incorrect answers when a non-zero center is used. (Note that the default center is the median, not zero, so this bug should affect most users ofmedian_absolute_deviation.)This pull request also provides unit tests for the non-zero center case.