This repository was archived by the owner on Dec 31, 2023. It is now read-only.
Fix models to support pydantic orm_mode #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See GitHub PR fastapi#43 fastapi#43 See GitHub issue fastapi#72 fastapi#72 When viewing the user profile, name and email weren't showing up. Docker Compose logs showed a pydantic error: https://pydantic-docs.helpmanual.io/ ``` backend_1 | pydantic.error_wrappers.ValidationError: 1 validation error for User backend_1 | response -> 0 backend_1 | value is not a valid dict (type=type_error.dict) ``` Pydantic orm_mode is needed. This commit will update the database models to use pydantic orm_mode, with cleaner syntax than the fix suggested in issue fastapi#72 (by adding class Config directly to the base class).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GitHub PR 43
fastapi#43
See GitHub issue 72
fastapi#72
When viewing the user profile, name and email weren't showing up.
Docker Compose logs showed a pydantic error:
https://pydantic-docs.helpmanual.io/
Pydantic orm_mode is needed. This commit will update the database models
to use pydantic orm_mode, with cleaner syntax than the fix suggested in
issue fastapi#72 (by adding class Config directly to the base class).