Skip to content

Conversation

@KoushikBaagh
Copy link

@KoushikBaagh KoushikBaagh commented Jun 17, 2024

Resolves

Added CI script to check for rewards requests before rewards opt-in.
Link to the issue : brave/brave-browser#14278
@diracdeltas @kjozwiak @iefremov @jumde , please check the PR

Methodology

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@KoushikBaagh KoushikBaagh requested review from a team and iefremov as code owners June 17, 2024 11:28
@KoushikBaagh
Copy link
Author

@iefremov @diracdeltas
Kindly review this PR

@mihaiplesa mihaiplesa requested review from a team and removed request for iefremov September 10, 2025 13:50
@mihaiplesa mihaiplesa requested a review from a team as a code owner November 4, 2025 12:16
@goodov
Copy link
Member

goodov commented Nov 4, 2025

I think this change makes sense. cc @brave/rewards-client

@KoushikBaagh wonder if you would like to rebase this PR using the latest master branch or pass this to our team so they can land this on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants