Skip to content

Conversation

@LorenzoMinto
Copy link
Contributor

@LorenzoMinto LorenzoMinto commented Jun 17, 2024

Resolves brave/brave-browser#39096

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

}
}

// Language fallback
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do without this step. Might be too general

// Regional fallback
std::string country_code = requested_locale.substr(requested_locale.find('_') + 1);
for (const auto& locale : available_locales) {
if (locale.substr(locale.find('_') + 1) == country_code) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we enforce priority? For example, when en_US, es_US are both there but the user has it_US? We should have a regional default, i.e. en_US

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, do you think this is that useful? Say I only speak Spanish, so my locale is es_US but we only have en_US, I'm not going to be thrilled that I'm getting a feed in English.

More concretely, I lived in Poland for a while, but I didn't speak much Polish, so my locale was en_PL - a feed in Polish wouldn't have been that useful for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Brave News]: Improve fallback strategy for news localization

3 participants