Skip to content

Conversation

@cuba
Copy link
Contributor

@cuba cuba commented Jun 26, 2024

Resolves brave/brave-browser#39402

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issue for STR

Screenshots

Screenshot 2024-06-26 at 1 33 18 PM

Simulator Screenshot - iPhone 14 Pro - 2024-06-26 at 13 32 38

@cuba cuba requested a review from a team as a code owner June 26, 2024 19:30
@cuba cuba force-pushed the js/youtube-request-blocking-script-flag branch from 761ce8e to 53e755a Compare June 26, 2024 19:30
@cuba cuba force-pushed the js/youtube-request-blocking-script-flag branch from 53e755a to a9b604a Compare June 26, 2024 21:51
@cuba cuba force-pushed the js/youtube-request-blocking-script-flag branch from a9b604a to 5ad5259 Compare July 4, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a feature flag to disable request blocking script on YouTube

3 participants