Skip to content

Conversation

@claucece
Copy link
Member

@claucece claucece commented Jul 4, 2024

Resolves brave/brave-browser#31872

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@claucece claucece requested a review from a team as a code owner July 4, 2024 19:13
@claucece
Copy link
Member Author

claucece commented Jul 4, 2024

cc. @ShivanKaul

@ShivanKaul ShivanKaul requested a review from bridiver July 4, 2024 19:14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely does not seem like the right fix here. It doesn't make sense to have an empty string for IDS_REQUEST_OTR_TITLE, we would just get rid of it entirely, but I'm not sure how this changes the behavior.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this needs tests

// Creates a request-otr infobar and delegate and adds the infobar to
// |infobar_manager|.
static void Create(infobars::ContentInfoBarManager* infobar_manager);
void TestAccept() { Accept(); }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add FRIEND_TEST_ALL_PREFIXES for the test class instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OTR] Existing History entries get renamed to Sensitive Website because of the Interstitial page.

2 participants