-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Resolves Issue 31872 #24514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Resolves Issue 31872 #24514
Conversation
|
cc. @ShivanKaul |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely does not seem like the right fix here. It doesn't make sense to have an empty string for IDS_REQUEST_OTR_TITLE, we would just get rid of it entirely, but I'm not sure how this changes the behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this needs tests
| // Creates a request-otr infobar and delegate and adds the infobar to | ||
| // |infobar_manager|. | ||
| static void Create(infobars::ContentInfoBarManager* infobar_manager); | ||
| void TestAccept() { Accept(); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add FRIEND_TEST_ALL_PREFIXES for the test class instead
Resolves brave/brave-browser#31872
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: