Skip to content

[iOS] Add an explicit "Block connections without VPN" setting to VPN (VPN Kill Switch Toggle) #24663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soner-yuksel wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[iOS] Add an explicit "Block connections without VPN" setting to VPN (VPN Kill Switch Toggle) #24663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7c6827b
Adding loading proper sections and organization
soner-yuksel Jul 8, 2024
493a932
Adding Localization to the switch
soner-yuksel Jul 9, 2024
095b6a5
Adding entry point for reconnect logic
soner-yuksel Jul 10, 2024
82c8d8d
Handlling Kill Switch enable and error case
soner-yuksel Jul 11, 2024
3915039
Removing unnecessary localization keys
soner-yuksel Jul 15, 2024
f1eb20a
Final localization changes
soner-yuksel Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ios/brave-ios/Sources/BraveVPN/BraveVPN.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,15 +188,17 @@ public class BraveVPN {

/// Reconnects to the vpn.
/// The vpn must be configured prior to that otherwise it does nothing.
public static func reconnect() {
public static func reconnect(completion: ((Bool) -> Void)? = nil) {
if reconnectPending {
logAndStoreError("Can't reconnect the vpn while another reconnect is pending.")
return
}

reconnectPending = true

connectToVPN()
connectToVPN { status in
completion?(status)
}
}

/// Disconnects the vpn.
Expand Down
Loading