Skip to content

Conversation

@jagadeshjai
Copy link
Collaborator

  • Hide brave talks card on new tab by default.

Resolves brave/brave-browser#39743

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@jagadeshjai jagadeshjai force-pushed the hide__brave_talk_card_by_default branch from 986ba55 to ecfcfcc Compare July 19, 2024 07:40
@simonhong
Copy link
Member

Can you run this unit test - DayZeroBrowserUIExptTest? It'll be broken with this change.

@jagadeshjai
Copy link
Collaborator Author

Can you run this unit test - DayZeroBrowserUIExptTest? It'll be broken with this change.

Actually, I haven't decided on the workings of this PR yet. I'm waiting for @rebron's reply at brave/brave-browser#39743 (comment).

But I thought of introducing kNewTabPageShowBraveTalkV2 for migration and obsoleting kNewTabPageShowBraveTalk.
@simonhong

@jagadeshjai jagadeshjai force-pushed the hide__brave_talk_card_by_default branch from ecfcfcc to 3213a83 Compare July 23, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide Talk card by default on new tab page

2 participants