Skip to content

Conversation

@josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Aug 13, 2024

Resolves brave/brave-browser#40438

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See STR in issue

@josheleonard josheleonard self-assigned this Aug 13, 2024
@josheleonard josheleonard requested review from a team as code owners August 13, 2024 22:49
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Aug 13, 2024
@github-actions
Copy link
Contributor

[puLL-Merge] - brave/brave-core@25114

Description

This PR introduces several changes to the Brave Wallet UI, primarily focusing on updating and standardizing the search bar component across various parts of the application. It also includes some minor updates to network selection and localization.

Changes

Changes

  1. components/brave_wallet/browser/brave_wallet_constants.h:

    • Added a new localized string for searching networks.
  2. components/brave_wallet_ui/components/buy-send-swap/select-currency/select-currency.tsx:

    • Updated import path for SearchBar component.
    • Changed SearchBar implementation to use the new onChange prop instead of action.
  3. components/brave_wallet_ui/components/desktop/card-headers/activity_page_header.tsx:

    • Updated SearchBar import and usage to match new API.
  4. components/brave_wallet_ui/components/desktop/hardware-wallet-connect/accounts_list.stories.tsx:

    • Updated props for HardwareWalletAccountsList component.
  5. components/brave_wallet_ui/components/desktop/hardware-wallet-connect/accounts_list.tsx:

    • Updated SearchBar import and usage.
  6. components/brave_wallet_ui/components/desktop/popup-modals/edit-visible-assets-modal/index.tsx:

    • Updated SearchBar import and usage.
  7. components/brave_wallet_ui/components/desktop/views/nfts/components/nfts.tsx:

    • Updated SearchBar import and usage.
    • Modified PortfolioActionButton to use disableResize prop.
  8. components/brave_wallet_ui/components/desktop/views/portfolio/components/token-lists/token-list.tsx:

    • Updated SearchBar import and usage.
    • Modified PortfolioActionButton to use disableResize prop.
  9. components/brave_wallet_ui/components/desktop/views/portfolio/style.ts:

    • Updated PortfolioActionButton styling and added disableResize prop.
  10. components/brave_wallet_ui/components/header_control_bar/header_control_bar.tsx:

    • Updated SearchBar import and usage.
    • Modified layout to use Column and Row components.
  11. components/brave_wallet_ui/components/shared/search-bar/index.tsx:

    • Removed old SearchBar implementation.
  12. components/brave_wallet_ui/components/shared/search_bar/search_bar.style.ts:

    • Added new styled components for SearchBar.
  13. components/brave_wallet_ui/components/shared/search_bar/search_bar.tsx:

    • Implemented new SearchBar component using Leo design system.
  14. Various other files:

    • Updated imports and usage of SearchBar component to match new API.
  15. components/brave_wallet_ui/stories/locale.ts:

    • Added new localized string for searching networks.
  16. components/resources/wallet_strings.grdp:

    • Added new message for searching networks placeholder.

Possible Issues

  • The removal of the old SearchBar component might cause issues in places where it's still being used with the old API.
  • The change in styling and behavior of the SearchBar component might affect the UI in unexpected ways across different parts of the application.

Security Hotspots

None identified. The changes are primarily UI-related and don't introduce any obvious security concerns.

@josheleonard josheleonard force-pushed the style--wallet--use-nala-component-for-search-inputs branch from e8744e4 to a1dcebf Compare August 13, 2024 23:02
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@muliswilliam muliswilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet puLL-Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wallet] Use Nala components for search inputs

6 participants