Skip to content

[Rebranding] Tabs search rebranding #25412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akshay24495 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Rebranding] Tabs search rebranding #25412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions chromium_src/chrome/browser/ui/webui/tab_search/tab_search_page_handler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#include "content/public/common/url_constants.h"
#include "url/gurl.h"

namespace {
GURL ReplaceChromeSchemeWithBrave(const GURL& url) {
if (url.scheme() == content::kChromeUIScheme) {
GURL::Replacements replacements;
replacements.SetSchemeStr(content::kBraveUIScheme);
return url.ReplaceComponents(replacements);
}
return url;
}
} // namespace

#include "src/chrome/browser/ui/webui/tab_search/tab_search_page_handler.cc"
28 changes: 28 additions & 0 deletions patches/chrome-browser-ui-webui-tab_search-tab_search_page_handler.cc.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
diff --git a/chrome/browser/ui/webui/tab_search/tab_search_page_handler.cc b/chrome/browser/ui/webui/tab_search/tab_search_page_handler.cc
index 1266c4eb9591c037b2b1409d6012c9554fe5bae0..39ebd2c1278538b5d3b6fd3509bb5ba49ec308fa 100644
--- a/chrome/browser/ui/webui/tab_search/tab_search_page_handler.cc
+++ b/chrome/browser/ui/webui/tab_search/tab_search_page_handler.cc
@@ -904,11 +904,11 @@ tab_search::mojom::TabPtr TabSearchPageHandler::GetTab(
// A visible URL is used when the a new tab is still loading.
// If it is cancelled during loading the visible URL becomes empty.
// We will display an empty URL as about:blank in Javascript.
- tab_data->url =
+ tab_data->url = ReplaceChromeSchemeWithBrave(
!last_committed_url.is_valid() || last_committed_url.is_empty()
? tab_renderer_data.visible_url
- : last_committed_url;
-
+ : last_committed_url);
+
if (tab_renderer_data.favicon.IsEmpty()) {
tab_data->is_default_favicon = true;
} else {
@@ -966,7 +966,7 @@ TabSearchPageHandler::GetRecentlyClosedTab(sessions::tab_restore::Tab* tab,
sessions::SerializedNavigationEntry& entry =
tab->navigations[tab->current_navigation_index];
recently_closed_tab->tab_id = tab->id.id();
- recently_closed_tab->url = entry.virtual_url();
+ recently_closed_tab->url = ReplaceChromeSchemeWithBrave(entry.virtual_url());
recently_closed_tab->title = entry.title().empty()
? recently_closed_tab->url.spec()
: base::UTF16ToUTF8(entry.title());