Skip to content

Added flag to disable Move all tabs to this window #25711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Biotronic wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −3
Open

Added flag to disable Move all tabs to this window #25711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e111604
Added flag to disable Move all tabs to this window
Biotronic Sep 25, 2024
fe2bc8a
Forgot a file
Biotronic Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions browser/about_flags.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,13 @@
kOsAll, \
FEATURE_VALUE_TYPE(brave_component_updater::kUseDevUpdaterUrl), \
}, \
{ \
"disable-move-all-tabs-to-window", \
"Disable 'Move all tabs to this window'", \
"Disable the stupid 'Move all tabs to this window' menu item." \
kOsAll, \
FEATURE_VALUE_TYPE(::features::kBraveDisableMoveToWindow), \
}, \
{ \
"brave-ntp-branded-wallpaper-demo", \
"New Tab Page Demo Branded Wallpaper", \
Expand Down
4 changes: 3 additions & 1 deletion browser/ui/brave_ui_features.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ namespace features {
BASE_FEATURE(kBraveNtpSearchWidget,
"BraveNtpSearchWidget",
base::FEATURE_ENABLED_BY_DEFAULT);

BASE_FEATURE(kBraveDisableMoveToWindow,
"kBraveDisableMoveToWindow",
base::FEATURE_DISABLED_BY_DEFAULT);
#if BUILDFLAG(IS_WIN)
// Enables window cloaking on window creation to prevent a white flash.
BASE_FEATURE(kBraveWorkaroundNewWindowFlash,
Expand Down
1 change: 1 addition & 0 deletions browser/ui/brave_ui_features.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
namespace features {

BASE_DECLARE_FEATURE(kBraveNtpSearchWidget);
BASE_DECLARE_FEATURE(kBraveDisableMoveToWindow);
#if BUILDFLAG(IS_WIN)
BASE_DECLARE_FEATURE(kBraveWorkaroundNewWindowFlash);
#endif // BUILDFLAG(IS_WIN)
Expand Down
6 changes: 4 additions & 2 deletions browser/ui/tabs/brave_tab_menu_model.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,10 @@ void BraveTabMenuModel::Build(Browser* browser,

AddItemWithStringId(CommandRestoreTab, GetRestoreTabCommandStringId());
AddItemWithStringId(CommandBookmarkAllTabs, IDS_TAB_CXMENU_BOOKMARK_ALL_TABS);
AddItemWithStringId(CommandBringAllTabsToThisWindow,
IDS_TAB_CXMENU_BRING_ALL_TABS_TO_THIS_WINDOW);
if (base::FeatureList::IsEnabled(features::kBraveDisableMoveToWindow)) {
AddItemWithStringId(CommandBringAllTabsToThisWindow,
IDS_TAB_CXMENU_BRING_ALL_TABS_TO_THIS_WINDOW);
}

AddSeparator(ui::NORMAL_SEPARATOR);
AddCheckItemWithStringId(CommandShowVerticalTabs,
Expand Down