Skip to content

Overlapping of delete button with search button #41213#26219

Open
Alec-Smith29 wants to merge 8 commits intobrave:masterfrom
Terrencezzz:Deal-with-overlapping-of-delet-button-with-search-button
Open

Overlapping of delete button with search button #41213#26219
Alec-Smith29 wants to merge 8 commits intobrave:masterfrom
Terrencezzz:Deal-with-overlapping-of-delet-button-with-search-button

Conversation

@Alec-Smith29
Copy link

Resolves brave/brave-browser#41213 by adding padding. Issue was fixed by adding padding to the delete button to prevent this from happening. Additional padding was also added to the navigation bar and search tool icon as at small resolutions some of these icons also overlapped which made some elements inaccessible.
The padding added was using em units as opposed to px. Unsure of which is the preferred option for this repository

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overlapping of Delete button with Search Icon

1 participant