Skip to content

Reorder functions in ai chat service#27690

Open
Arif-Khalid wants to merge 1 commit intobrave:masterfrom
Arif-Khalid:issues/43294
Open

Reorder functions in ai chat service#27690
Arif-Khalid wants to merge 1 commit intobrave:masterfrom
Arif-Khalid:issues/43294

Conversation

@Arif-Khalid
Copy link

@Arif-Khalid Arif-Khalid commented Feb 16, 2025

Resolves brave/brave-browser#43294

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AI Chat]: Reorder functions in ai_chat_service.cc to match order in header file

1 participant