-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(wallet): iOS Zcash account creation and balance fetching #28671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@stoletheminerals i didn't create a sec-review for this since it's UI changes + using Wallet Core mojom api. Please let me know if it needs one. Adding you as a reviewer in case you need to go through the changes. |
|
Thanks @nuo-xu . If you don't mind please create a review issue and add a priority, as I have a few other big reviews in the pipeline. |
...BraveWallet/Assets.xcassets/Brave Wallet/Asset Icons/zcash-asset-icon.imageset/[email protected]
Outdated
Show resolved
Hide resolved
ios/brave-ios/Sources/BraveWallet/Extensions/BraveWalletExtensions.swift
Show resolved
Hide resolved
ios/brave-ios/Sources/BraveWallet/Extensions/BraveWalletExtensions.swift
Outdated
Show resolved
Hide resolved
ios/brave-ios/Sources/BraveWallet/Extensions/BraveWalletExtensions.swift
Outdated
Show resolved
Hide resolved
...rave-ios/Sources/BraveWallet/Assets.xcassets/Brave Wallet/Asset Icons/neon.imageset/neon.png
Outdated
Show resolved
Hide resolved
ios/brave-ios/Sources/Brave/Frontend/Settings/Debug/Brave Wallet/BraveWalletDebugMenu.swift
Show resolved
Hide resolved
ios/brave-ios/Sources/BraveWallet/Crypto/SelectAccountTokenView.swift
Outdated
Show resolved
Hide resolved
|
Chromium major version is behind target branch (135.0.7049.84 vs 136.0.7103.25). Please rebase. |
e21cdfd to
3d96b3a
Compare
3d96b3a to
e880d6f
Compare
StephenHeaps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to select Preserve Vector Data for the svg images, otherwise LGTM 🐎.
ios/brave-ios/Sources/BraveWallet/Crypto/Stores/SelectAccountTokenStore.swift
Show resolved
Hide resolved
...ios/Sources/BraveWallet/Assets.xcassets/Brave Wallet/Asset Icons/avax.imageset/Contents.json
Show resolved
Hide resolved
52eeca1 to
f64c27a
Compare
f64c27a to
8642f6a
Compare
2a12deb to
52bf6ab
Compare
52bf6ab to
ead4d8c
Compare
|
Chromium major version is behind target branch (136.0.7103.93 vs 137.0.7151.16). Please rebase. |
ead4d8c to
8520144
Compare
8520144 to
bf5e5a3
Compare
…on. Unit test WIP
… for zcash account and balance.
bf5e5a3 to
550d6d5
Compare
|
[puLL-Merge] - brave/brave-core@28671 DescriptionThis PR adds ZCash wallet support to the Brave iOS app. It integrates ZCash functionality alongside existing cryptocurrencies like Bitcoin and Ethereum by adding ZCash account management, asset display, and transaction capabilities. The changes include UI updates, new asset icons, and support for both mainnet and testnet ZCash networks. ChangesChangesWallet Service Integration
Asset Icons
Account Management
Account Operations
UI/UX Updates
Model Extensions
Preferences
sequenceDiagram
BrowserViewController->>WalletStore: Initialize
WalletStore->>ZCashWalletServiceFactory: get(privateMode:)
ZCashWalletServiceFactory-->>WalletStore: Returns zcashWalletService
WalletStore->>CryptoStore: Initialize with zcashWalletService
CryptoStore->>AccountsStore: Initialize with zcashWalletService
CryptoStore->>BuyTokenStore: Initialize with zcashWalletService
CryptoStore->>SendTokenStore: Initialize with zcashWalletService
CryptoStore->>AssetDetailStore: Initialize with zcashWalletService
CryptoStore->>AccountActivityStore: Initialize with zcashWalletService
CryptoStore->>PortfolioStore: Initialize with zcashWalletService
User->>BraveWalletDebugMenu: Toggle "Enable Zcash Testnet"
BraveWalletDebugMenu->>Preferences: Update isZcashTestnetEnabled
User->>AddAccountView: Create ZCash Account
AddAccountView->>KeyringStore: Create Account
KeyringStore->>ZCashWalletService: Initialize account
User->>AccountActivityView: View ZCash Account
AccountActivityView->>ZCashWalletService: fetchZECTransparentBalances
ZCashWalletService-->>AccountActivityView: Return balance
User->>DepositTokenView: Get deposit address
DepositTokenView->>ZCashWalletService: zCashAccountInfo
ZCashWalletService-->>DepositTokenView: Returns nextTransparentReceiveAddress
|
|
Released in v1.81.12 |
Resolves brave/brave-browser#45445
Test Plan