[WDP Native v2] Add value transforms pt. 2#30822
Open
DJAndries wants to merge 2 commits intowdp-native-v2-transforms1from
Open
[WDP Native v2] Add value transforms pt. 2#30822DJAndries wants to merge 2 commits intowdp-native-v2-transforms1from
DJAndries wants to merge 2 commits intowdp-native-v2-transforms1from
Conversation
DJAndries
force-pushed
the
wdp-native-v2-transforms1
branch
from
cb3d1bc to
23eba7b
Compare
DJAndries
force-pushed
the
wdp-native-v2-transforms2
branch
from
46290d5 to
c4736b2
Compare
DJAndries
force-pushed
the
wdp-native-v2-transforms1
branch
from
23eba7b to
66bf8df
Compare
DJAndries
force-pushed
the
wdp-native-v2-transforms2
branch
from
c4736b2 to
e9ccd84
Compare
fmarier
reviewed
Sep 6, 2025
| result = transform->Process("not-a-url"); | ||
| EXPECT_EQ(result, std::nullopt); | ||
|
|
||
| // Test URL with no matching params |
Member
There was a problem hiding this comment.
I'd suggest another one just to emphasize that we're not making assumptions about the format of the query string in this function:
https://example.com?utm_source=google;utm_medium=cpc;utm_content=something
(should be untouched)
| R"(["removeParams", ["utm_source", "utm_medium", "fbclid"]])"); | ||
| ASSERT_TRUE(transform); | ||
|
|
||
| // Test URL with params to remove |
Member
There was a problem hiding this comment.
Another one to show that we're not urldecoding the parameters:
https://example.com?utm_source=google&utm_medium=cpc&redirect=https%3A%2F%2Fexample.net%3Futm_source%3Dbing%26utm_medium%3Dcpm
The expected output is https://example.com?redirect=https%3A%2F%2Fexample.net%3Futm_source%3Dbing%26utm_medium%3Dcpm
DJAndries
force-pushed
the
wdp-native-v2-transforms1
branch
from
66bf8df to
f72a8ea
Compare
DJAndries
force-pushed
the
wdp-native-v2-transforms2
branch
from
e9ccd84 to
1a0394f
Compare
DJAndries
force-pushed
the
wdp-native-v2-transforms1
branch
from
f72a8ea to
f61fa51
Compare
DJAndries
force-pushed
the
wdp-native-v2-transforms2
branch
from
1a0394f to
04c7645
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#48953
Based off #30821