Skip to content

[Cardano] Fix GetUtxos arguments handling #31872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cypt4 merged 3 commits into from
Oct 22, 2025
Merged

[Cardano] Fix GetUtxos arguments handling #31872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0613569
[Cardano] Fix GetUtxo arguments handling
cypt4 Oct 17, 2025
ce13d82
Fix paginate error
cypt4 Oct 20, 2025
595482f
Review fix
cypt4 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
322 changes: 247 additions & 75 deletions browser/brave_wallet/cardano_provider_renderer_browsertest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,67 +794,206 @@ IN_PROC_BROWSER_TEST_F(CardanoProviderRendererTest, GetRewardAddresses_Error) {
}

IN_PROC_BROWSER_TEST_F(CardanoProviderRendererTest, GetUtxos) {
TestCardanoProvider* provider = test_content_browser_client_.GetProvider(
web_contents(browser())->GetPrimaryMainFrame());
auto cardano_api = std::make_unique<TestCardanoApi>();
ON_CALL(*provider, Enable(_, _))
.WillByDefault([&](mojo::PendingReceiver<mojom::CardanoApi> receiver,
TestCardanoProvider::EnableCallback callback) {
cardano_api->BindReceiver(std::move(receiver));
std::move(callback).Run(nullptr);
});
ON_CALL(*cardano_api, GetUtxos(_, _, _))
.WillByDefault([&](const std::optional<std::string>& amount,
mojom::CardanoProviderPaginationPtr paginate,
TestCardanoApi::GetUtxosCallback callback) {
EXPECT_EQ("1", amount.value());
EXPECT_EQ(2, paginate->page);
EXPECT_EQ(3, paginate->limit);
std::move(callback).Run(std::vector<std::string>({"1", "2"}), nullptr);
});
// Amount and pagination are defined.
{
TestCardanoProvider* provider = test_content_browser_client_.GetProvider(
web_contents(browser())->GetPrimaryMainFrame());
auto cardano_api = std::make_unique<TestCardanoApi>();
ON_CALL(*provider, Enable(_, _))
.WillByDefault([&](mojo::PendingReceiver<mojom::CardanoApi> receiver,
TestCardanoProvider::EnableCallback callback) {
cardano_api->BindReceiver(std::move(receiver));
std::move(callback).Run(nullptr);
});
ON_CALL(*cardano_api, GetUtxos(_, _, _))
.WillByDefault([&](const std::optional<std::string>& amount,
mojom::CardanoProviderPaginationPtr paginate,
TestCardanoApi::GetUtxosCallback callback) {
EXPECT_EQ("1", amount.value());
EXPECT_EQ(2, paginate->page);
EXPECT_EQ(3, paginate->limit);
std::move(callback).Run(std::vector<std::string>({"1", "2"}),
nullptr);
});

auto result = EvalJs(web_contents(browser()),
"(async () => { return await (await "
"window.cardano.brave.enable()).getUtxos(\"1\", {page: "
"2, limit:3}) })();");
auto result =
EvalJs(web_contents(browser()),
"(async () => { return await (await "
"window.cardano.brave.enable()).getUtxos(\"1\", {page: "
"2, limit:3}) })();");

base::Value::List list_value;
list_value.Append(base::Value("1"));
list_value.Append(base::Value("2"));
EXPECT_EQ(list_value, result);
}
base::Value::List list_value;
list_value.Append(base::Value("1"));
list_value.Append(base::Value("2"));
EXPECT_EQ(list_value, result);
}

IN_PROC_BROWSER_TEST_F(CardanoProviderRendererTest, GetUtxos_NoArgs) {
TestCardanoProvider* provider = test_content_browser_client_.GetProvider(
web_contents(browser())->GetPrimaryMainFrame());
auto cardano_api = std::make_unique<TestCardanoApi>();
ON_CALL(*provider, Enable(_, _))
.WillByDefault([&](mojo::PendingReceiver<mojom::CardanoApi> receiver,
TestCardanoProvider::EnableCallback callback) {
cardano_api->BindReceiver(std::move(receiver));
std::move(callback).Run(nullptr);
});
ON_CALL(*cardano_api, GetUtxos(_, _, _))
.WillByDefault([&](const std::optional<std::string>& amount,
mojom::CardanoProviderPaginationPtr paginate,
TestCardanoApi::GetUtxosCallback callback) {
EXPECT_FALSE(amount);
EXPECT_FALSE(paginate);
std::move(callback).Run(std::vector<std::string>({"1", "2"}), nullptr);
});
// Amount undefined, pagination not defined.
{
TestCardanoProvider* provider = test_content_browser_client_.GetProvider(
web_contents(browser())->GetPrimaryMainFrame());
auto cardano_api = std::make_unique<TestCardanoApi>();
ON_CALL(*provider, Enable(_, _))
.WillByDefault([&](mojo::PendingReceiver<mojom::CardanoApi> receiver,
TestCardanoProvider::EnableCallback callback) {
cardano_api->BindReceiver(std::move(receiver));
std::move(callback).Run(nullptr);
});
ON_CALL(*cardano_api, GetUtxos(_, _, _))
.WillByDefault([&](const std::optional<std::string>& amount,
mojom::CardanoProviderPaginationPtr paginate,
TestCardanoApi::GetUtxosCallback callback) {
EXPECT_FALSE(amount);
EXPECT_FALSE(paginate);
std::move(callback).Run(std::vector<std::string>({"1", "2"}),
nullptr);
});

auto result = EvalJs(web_contents(browser()),
"(async () => { return await (await "
"window.cardano.brave.enable()).getUtxos() })();");
auto result =
EvalJs(web_contents(browser()),
"(async () => { return await (await "
"window.cardano.brave.enable()).getUtxos(undefined) })();");

base::Value::List list_value;
list_value.Append(base::Value("1"));
list_value.Append(base::Value("2"));
base::Value::List list_value;
list_value.Append(base::Value("1"));
list_value.Append(base::Value("2"));
EXPECT_EQ(list_value, result);
}

EXPECT_EQ(list_value, result);
// Amount undefined with defined pagination.
{
TestCardanoProvider* provider = test_content_browser_client_.GetProvider(
web_contents(browser())->GetPrimaryMainFrame());
auto cardano_api = std::make_unique<TestCardanoApi>();
ON_CALL(*provider, Enable(_, _))
.WillByDefault([&](mojo::PendingReceiver<mojom::CardanoApi> receiver,
TestCardanoProvider::EnableCallback callback) {
cardano_api->BindReceiver(std::move(receiver));
std::move(callback).Run(nullptr);
});
ON_CALL(*cardano_api, GetUtxos(_, _, _))
.WillByDefault([&](const std::optional<std::string>& amount,
mojom::CardanoProviderPaginationPtr paginate,
TestCardanoApi::GetUtxosCallback callback) {
EXPECT_FALSE(amount);
EXPECT_EQ(2, paginate->page);
EXPECT_EQ(3, paginate->limit);
std::move(callback).Run(std::vector<std::string>({"1", "2"}),
nullptr);
});

auto result =
EvalJs(web_contents(browser()),
"(async () => { return await (await "
"window.cardano.brave.enable()).getUtxos(undefined, {page: "
"2, limit:3}) })();");

base::Value::List list_value;
list_value.Append(base::Value("1"));
list_value.Append(base::Value("2"));
EXPECT_EQ(list_value, result);
}

// Both undefined.
{
TestCardanoProvider* provider = test_content_browser_client_.GetProvider(
web_contents(browser())->GetPrimaryMainFrame());
auto cardano_api = std::make_unique<TestCardanoApi>();
ON_CALL(*provider, Enable(_, _))
.WillByDefault([&](mojo::PendingReceiver<mojom::CardanoApi> receiver,
TestCardanoProvider::EnableCallback callback) {
cardano_api->BindReceiver(std::move(receiver));
std::move(callback).Run(nullptr);
});
ON_CALL(*cardano_api, GetUtxos(_, _, _))
.WillByDefault([&](const std::optional<std::string>& amount,
mojom::CardanoProviderPaginationPtr paginate,
TestCardanoApi::GetUtxosCallback callback) {
EXPECT_FALSE(amount);
EXPECT_FALSE(paginate);
std::move(callback).Run(std::vector<std::string>({"1", "2"}),
nullptr);
});

auto result = EvalJs(
web_contents(browser()),
"(async () => { return await (await "
"window.cardano.brave.enable()).getUtxos(undefined, undefined) })();");

base::Value::List list_value;
list_value.Append(base::Value("1"));
list_value.Append(base::Value("2"));
EXPECT_EQ(list_value, result);
}

// With amount, pagination not defined.
{
TestCardanoProvider* provider = test_content_browser_client_.GetProvider(
web_contents(browser())->GetPrimaryMainFrame());
auto cardano_api = std::make_unique<TestCardanoApi>();
ON_CALL(*provider, Enable(_, _))
.WillByDefault([&](mojo::PendingReceiver<mojom::CardanoApi> receiver,
TestCardanoProvider::EnableCallback callback) {
cardano_api->BindReceiver(std::move(receiver));
std::move(callback).Run(nullptr);
});
ON_CALL(*cardano_api, GetUtxos(_, _, _))
.WillByDefault([&](const std::optional<std::string>& amount,
mojom::CardanoProviderPaginationPtr paginate,
TestCardanoApi::GetUtxosCallback callback) {
EXPECT_EQ("1", amount);
EXPECT_FALSE(paginate);
std::move(callback).Run(std::vector<std::string>({"1", "2"}),
nullptr);
});

auto result =
EvalJs(web_contents(browser()),
"(async () => { return await (await "
"window.cardano.brave.enable()).getUtxos(\"1\") })();");

base::Value::List list_value;
list_value.Append(base::Value("1"));
list_value.Append(base::Value("2"));

EXPECT_EQ(list_value, result);
}

// With amount, pagination is undefined.
{
TestCardanoProvider* provider = test_content_browser_client_.GetProvider(
web_contents(browser())->GetPrimaryMainFrame());
auto cardano_api = std::make_unique<TestCardanoApi>();
ON_CALL(*provider, Enable(_, _))
.WillByDefault([&](mojo::PendingReceiver<mojom::CardanoApi> receiver,
TestCardanoProvider::EnableCallback callback) {
cardano_api->BindReceiver(std::move(receiver));
std::move(callback).Run(nullptr);
});
ON_CALL(*cardano_api, GetUtxos(_, _, _))
.WillByDefault([&](const std::optional<std::string>& amount,
mojom::CardanoProviderPaginationPtr paginate,
TestCardanoApi::GetUtxosCallback callback) {
EXPECT_EQ("1", amount);
EXPECT_FALSE(paginate);
std::move(callback).Run(std::vector<std::string>({"1", "2"}),
nullptr);
});

auto result = EvalJs(
web_contents(browser()),
"(async () => { return await (await "
"window.cardano.brave.enable()).getUtxos(\"1\", undefined) })();");

base::Value::List list_value;
list_value.Append(base::Value("1"));
list_value.Append(base::Value("2"));

EXPECT_EQ(list_value, result);
}
}

IN_PROC_BROWSER_TEST_F(CardanoProviderRendererTest, GetUtxos_NoPagination) {
IN_PROC_BROWSER_TEST_F(CardanoProviderRendererTest, GetUtxos_NoArgs) {
TestCardanoProvider* provider = test_content_browser_client_.GetProvider(
web_contents(browser())->GetPrimaryMainFrame());
auto cardano_api = std::make_unique<TestCardanoApi>();
Expand All @@ -868,14 +1007,14 @@ IN_PROC_BROWSER_TEST_F(CardanoProviderRendererTest, GetUtxos_NoPagination) {
.WillByDefault([&](const std::optional<std::string>& amount,
mojom::CardanoProviderPaginationPtr paginate,
TestCardanoApi::GetUtxosCallback callback) {
EXPECT_EQ("1", amount);
EXPECT_FALSE(amount);
EXPECT_FALSE(paginate);
std::move(callback).Run(std::vector<std::string>({"1", "2"}), nullptr);
});

auto result = EvalJs(web_contents(browser()),
"(async () => { return await (await "
"window.cardano.brave.enable()).getUtxos(\"1\") })();");
"window.cardano.brave.enable()).getUtxos() })();");

base::Value::List list_value;
list_value.Append(base::Value("1"));
Expand All @@ -885,27 +1024,60 @@ IN_PROC_BROWSER_TEST_F(CardanoProviderRendererTest, GetUtxos_NoPagination) {
}

IN_PROC_BROWSER_TEST_F(CardanoProviderRendererTest, GetUtxos_WrongArguments) {
TestCardanoProvider* provider = test_content_browser_client_.GetProvider(
web_contents(browser())->GetPrimaryMainFrame());
auto cardano_api = std::make_unique<TestCardanoApi>();
ON_CALL(*provider, Enable(_, _))
.WillByDefault([&](mojo::PendingReceiver<mojom::CardanoApi> receiver,
TestCardanoProvider::EnableCallback callback) {
cardano_api->BindReceiver(std::move(receiver));
std::move(callback).Run(nullptr);
});
ON_CALL(*cardano_api, GetUtxos(_, _, _))
.WillByDefault([&](const std::optional<std::string>& amount,
mojom::CardanoProviderPaginationPtr paginate,
TestCardanoApi::GetUtxosCallback callback) {
std::move(callback).Run(std::vector<std::string>({"1", "2"}), nullptr);
});
// Wrong argument types.
{
TestCardanoProvider* provider = test_content_browser_client_.GetProvider(
web_contents(browser())->GetPrimaryMainFrame());
auto cardano_api = std::make_unique<TestCardanoApi>();
ON_CALL(*provider, Enable(_, _))
.WillByDefault([&](mojo::PendingReceiver<mojom::CardanoApi> receiver,
TestCardanoProvider::EnableCallback callback) {
cardano_api->BindReceiver(std::move(receiver));
std::move(callback).Run(nullptr);
});
ON_CALL(*cardano_api, GetUtxos(_, _, _))
.WillByDefault([&](const std::optional<std::string>& amount,
mojom::CardanoProviderPaginationPtr paginate,
TestCardanoApi::GetUtxosCallback callback) {
std::move(callback).Run(std::vector<std::string>({"1", "2"}),
nullptr);
});

{
auto result =
EvalJs(web_contents(browser()),
"(async () => { return await (await "
"window.cardano.brave.enable()).getUtxos(1, 2) })();");
EXPECT_FALSE(result.is_ok());
}
}

// Wrong arguments amount.
{
auto result = EvalJs(web_contents(browser()),
"(async () => { return await (await "
"window.cardano.brave.enable()).getUtxos(1, 2) })();");
EXPECT_FALSE(result.is_ok());
TestCardanoProvider* provider = test_content_browser_client_.GetProvider(
web_contents(browser())->GetPrimaryMainFrame());
auto cardano_api = std::make_unique<TestCardanoApi>();
ON_CALL(*provider, Enable(_, _))
.WillByDefault([&](mojo::PendingReceiver<mojom::CardanoApi> receiver,
TestCardanoProvider::EnableCallback callback) {
cardano_api->BindReceiver(std::move(receiver));
std::move(callback).Run(nullptr);
});
ON_CALL(*cardano_api, GetUtxos(_, _, _))
.WillByDefault([&](const std::optional<std::string>& amount,
mojom::CardanoProviderPaginationPtr paginate,
TestCardanoApi::GetUtxosCallback callback) {
std::move(callback).Run(std::vector<std::string>({"1", "2"}),
nullptr);
});

{
auto result = EvalJs(web_contents(browser()),
"(async () => { return await (await "
"window.cardano.brave.enable()).getUtxos(undefined, "
"undefined, undefined) })();");
EXPECT_FALSE(result.is_ok());
}
}
}

Expand Down Expand Up @@ -937,7 +1109,7 @@ IN_PROC_BROWSER_TEST_F(CardanoProviderRendererTest, GetUtxos_WrongPagination) {
"window.cardano.brave.enable()).getUtxos() } "
"catch(error) {return error} })();");
base::Value::Dict dict_value;
dict_value.Set("maxNumber", base::Value(2));
dict_value.Set("maxSize", base::Value(2));

EXPECT_EQ(dict_value, result);
}
Expand Down
Loading
Loading