[AI Chat]: Fix Agent Mode Learn More Link Click#34618
[AI Chat]: Fix Agent Mode Learn More Link Click#34618Douglashdaniel wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
CI/storybook-url
|
A Storybook has been deployed to preview UI for the latest push |
Douglashdaniel
force-pushed
the
ai-chat-fix-agent-learn-more-link-click
branch
from
9b97caa to
e2f541a
Compare
fallaciousreasoning
left a comment
fallaciousreasoning
left a comment
There was a problem hiding this comment.
lgtm % question about whether this works as a normal link
| props.context.openURL(mojomUrl) | ||
| }, [props.context.openURL]) | ||
| aiChatContext.api.uiHandler.openURL(mojomUrl) | ||
| }, [aiChatContext.api.uiHandler]) |
There was a problem hiding this comment.
Hey, I think you might not need to go through openURL anymore - can you check if this just works as a normal <a> tag?
There was a problem hiding this comment.
Tested, does not work in Sidebar unfortunately.
There was a problem hiding this comment.
Huh weird, because other links do (like the inline search urls).
petemill
left a comment
petemill
left a comment
There was a problem hiding this comment.
I'm ok with this if we're ok breaking the ai_rewriter page, since it does not have a useAIChat() ability, and that's the reason Input specifies all its props.
(Though we should remove ai_rewriter if that's the case)
Was it a challenge fixing the openURL prop?
|
I'd be surprised if AI rewriter is working 😆 |
5 participants
Description
Fixes a bug where clicking
Learn moreforAgent Modein the input box would do nothing.Resolves brave/brave-browser#53381
Screen.Recording.1.mov