Add Brave Search metrics (uplift to 1.89.x)#34625
Open
Conversation
* Add metrics for Brave queries per day * Move QPD metrics to separate class * Add search metrics test * Refactor search metrics to not use daily storage, report after 24 hours has elapsed * Add Yahoo/DDG default histogram names * Remove check deref include * Move unit test to components * Clear query counts on history clear * Add check for registry * Fix rebase error
* Add omnibox search percentage metrics * Add NTP search percentage metric * Include private queries in search metrics * Update metric_names.h * Fix * Trigger `ReportDailyMetrics` from `PageMetrics::ReportAllMetrics` * Address PR feedback * Fix after Chromium upgrade, misc fixes after rebase * Add CHECK_GT * Add missing metric names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uplift of #33884
Uplift of #33951
Resolves brave/brave-browser#52857
Resolves brave/brave-browser#52782