Skip BrowserView::Layout() after exiting fullscreen mode (uplift to 1.89.x)#34636
Merged
Skip BrowserView::Layout() after exiting fullscreen mode (uplift to 1.89.x)#34636
Conversation
On Mac, browser view is trying to layout its children from BrowserView::Layout() after exiting fullscreen mode. This can cause the browser view to be laid out with the wrong bounds. This patch skips the layout if the browser view is not in the visual client area of the browser frame view.
kjozwiak
approved these changes
Mar 11, 2026
Member
kjozwiak
left a comment
kjozwiak
left a comment
There was a problem hiding this comment.
Uplift into 1.89.x approved 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uplift of #34590
Resolves brave/brave-browser#53470
Pre-approval checklist:
Pre-merge checklist:
Post-merge checklist: