amazonka: Catch auth exceptions in the correct order #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were recursing through the provider list inside the exception handler, which resulted in authentication methods being tried back-to-front.
endgame
force-pushed
the
catch-auth-exceptions-correctly
branch
from
1f092d0 to
cf174ae
Compare
Contributor
|
I can confirm the slow down is gone for me. |
Collaborator
Author
|
Thank you. |
jerith666
added a commit
to jerith666/nixpkgs
that referenced
this pull request
Jun 23, 2025
to pick up auth fix brendanhay/amazonka#1029
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were recursing through the provider list inside the exception handler, which resulted in authentication methods being tried back-to-front.
@matteoeghirotta @pbrisbin please confirm whether this fixes your issue.
Closes #1023
Fixes #1018