Failing array-tests

[booo]

There are some failing tests. Maybe someone can take look at this:

http://travis-ci.org/#!/booo/node-postgres/builds/1254978

Regards
Philipp

[brianc]

that's awesome you're trying to get this to run on travis. Do you know what version of postgres it was running against? I might have overlooked it but didn't see it in the logs.

[booo]

The version used by travis should be PostgreSQL 9.1.x (http://about.travis-ci.org/docs/user/ci-environment/). If you are interested in the exact version I can add a script which checks for the version.

Anyway, the tests also fail in my local environment with PostgreSQL 9.1.3.

If we find a solution for the array problem I can try to finish the travis setup.

Best Regards
Philipp

[zenlor]

in my local environment this: "SELECT '{\"joe''\",jim'',\"bob\\\"\"}'::text[] as names" passes, while the current "SELECT '{\"joe''\",jim'',\"bob\\\\\"\"}'::text[] as names" will issue the error.

Don't know if there are issues with other node or postgres versions since it seems to be an escaping error (one more escaped backslash \\).

I'm running node 1.6.17 and PostgreSQL 9.1.3

[booo]

@aliem I can confirm this. We are talking about this line https://github.com/brianc/node-postgres/blob/master/test/integration/client/array-tests.js#L71 right? Would you like to add a pull request?

[zenlor]

I could but, on my production server with Postgres 9.0.3 and node 0.6.18 it issues an error :/

client.query("SELECT '{\"joe''\",jim'',\"bob\\\\\"\"}'::text[] as names", function(err, data){
  console.log('Old test')
  if (err) throw err;
  console.log(util.inspect(data.rows));
})
client.query("SELECT '{\"joe''\",jim'',\"bob\\\"\"}'::text[] as names", function(err, data){
  console.log('new test')
  if (err) throw err;
  console.log(util.inspect(data.rows));
})

outputs

Old test
[ { names: [ 'joe\'', 'jim\'', 'bob"' ] } ]
new test

/home/lorenzo/test/array.js:20
  if (err) throw err;
                 ^
error: malformed array literal: "{"joe'",jim',"bob""}"
    at [object Object].<anonymous> (/home/lorenzo/test/node_modules/pg/lib/connection.js:413:11)
    at [object Object].parseMessage (/home/lorenzo/test/node_modules/pg/lib/connection.js:288:17)
    at Socket.<anonymous> (/home/lorenzo/test/node_modules/pg/lib/connection.js:45:22)
    at Socket.emit (events.js:67:17)
    at TCP.onread (net.js:367:14)

[booo]

Here we go:

SELECT '{"joe''",jim'',"bob\""}'::text[] as names

This one is broken in 9.0.3:

SELECT '{"joe''",jim'',"bob\""}'::text[] as names
;
WARNING:  nonstandard use of escape in a string literal
LINE 1: SELECT '{"joe''",jim'',"bob\""}'::text[] as names
               ^
HINT:  Use the escape string syntax for escapes, e.g., E'\r\n'.
ERROR:  malformed array literal: "{"joe'",jim',"bob""}"
LINE 1: SELECT '{"joe''",jim'',"bob\""}'::text[] as names

But works in 9.1.4:

SELECT '{"joe''",jim'',"bob\""}'::text[] as names
;
        names        
---------------------
 {joe',jim',"bob\""}
(1 row)

SELECT '{"joe''",jim'',"bob\\""}'::text[] as names;

This one works in 9.0.3 but returns a warning:

SELECT '{"joe''",jim'',"bob\\""}'::text[] as names;
WARNING:  nonstandard use of \\ in a string literal
LINE 1: SELECT '{"joe''",jim'',"bob\\""}'::text[] as names;
               ^
HINT:  Use the escape string syntax for backslashes, e.g., E'\\'.
        names        
---------------------
 {joe',jim',"bob\""}
(1 row)

It fails in 9.1.4 with:

SELECT '{"joe''",jim'',"bob\\""}'::text[] as names;
ERROR:  malformed array literal: "{"joe'",jim',"bob\\""}"
LINE 1: SELECT '{"joe''",jim'',"bob\\""}'::text[] as names;

SELECT ARRAY['joe''', 'jim''', 'bob"'] AS names;

This one seems to work in 9.0.3 as well as 9.1.4. I propose we change the statement.

[booo]

@aliem would be nice if you could try my branch/fork and report back.

[brianc]

I'll try merging this in tonight. It's taken a while I don't have a 9.1.4 environment set up yet.