Fix tests skipped because of missing suffixes #2071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocha will happen eventually!
indeed it will! |
charmander
force-pushed
the
unintentional-test-skips
branch
9 times, most recently
from
2d92ee6 to
7182e9c
Compare
Will be made more visible when tests are ported to Mocha.
Should reveal a bug in the password enumerability work, I think.
charmander
force-pushed
the
unintentional-test-skips
branch
from
7182e9c to
225ed49
Compare
brianc
reviewed
Jan 13, 2020
|
This looks good! Will merge once tests pass. |
|
beautiful. and the tests still pass! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocha will happen eventually!