Fix of pool leaking #913
Closed
Fix of pool leaking #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2016
|
👍 Would be nice if this lands in master soon |
Closed
… brianc-master Conflicts: lib/defaults.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some bug with connection pool.
To reproduce it - you need connect to postgresql, start request and kill db process by
kill -9. Client will not be free on any time.To stop this, we can add heartbeat to net.Socket on pg.Client. To force backward capability heartbeat on default is 0. If heartbeat is 0, no heartbeat will be used.
I have tested it on my db, seems, that it works fine.
P.S. sorry for my English.