Remove unneeded files from gem package #228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orgads
added a commit
to orgads/fluentd-docker-image
that referenced
this pull request
Feb 29, 2024
Reduces the alpine image from 46M to 41M. yajl parts can be removed if/when brianmario/yajl-ruby#228 is merged and released.
orgads
added a commit
to orgads/fluentd-docker-image
that referenced
this pull request
Feb 29, 2024
Reduces the alpine image from 46M to 41M. yajl parts can be removed if/when brianmario/yajl-ruby#228 is merged and released. Signed-off-by: Orgad Shaneh <[email protected]>
|
@jhawthorn ping |
orgads
added a commit
to orgads/fluentd-docker-image
that referenced
this pull request
Sep 5, 2024
Reduces the alpine image from 46M to 41M. yajl parts can be removed if/when brianmario/yajl-ruby#228 is merged and released. Signed-off-by: Orgad Shaneh <[email protected]>
orgads
added a commit
to orgads/fluentd-docker-image
that referenced
this pull request
Sep 5, 2024
Reduces the alpine image from 46M to 36M, and debian image from 210M to 195M. yajl parts can be removed if/when brianmario/yajl-ruby#228 is merged and released. Signed-off-by: Orgad Shaneh <[email protected]>
|
ping |
|
At this point we should consider this a legacy gem, you could just use JSON and get better performance, so I'm reluctant to merge. This change has a danger of adding unwanted and uncommitted files. The gem also looks to be of a reasonable size. |
orgads
added a commit
to orgads/fluentd
that referenced
this pull request
Sep 10, 2025
yajl is much slower than json nowadays. See 1d5b0de and maintainer comment in brianmario/yajl-ruby#228.
orgads
added a commit
to orgads/fluentd
that referenced
this pull request
Sep 10, 2025
yajl is much slower than json nowadays. See 1d5b0de and maintainer comment in brianmario/yajl-ruby#228. Signed-off-by: Orgad Shaneh <[email protected]>
orgads
added a commit
to orgads/fluentd
that referenced
this pull request
Sep 10, 2025
yajl is much slower than json nowadays. See 1d5b0de and maintainer comment in brianmario/yajl-ruby#228. Signed-off-by: Orgad Shaneh <[email protected]>
|
What do you mean by "reasonable size"? The packed gem is 500K, and the extracted files are 4.2M. Stripping all but ext and lib leaves 540K, which is 87% less! How about running |
Watson1978
pushed a commit
to fluent/fluentd
that referenced
this pull request
Sep 22, 2025
yajl is much slower than json nowadays. See 1d5b0de and maintainer comment in brianmario/yajl-ruby#228. Signed-off-by: Orgad Shaneh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.