This repository was archived by the owner on Jun 1, 2022. It is now read-only.
add ability to add image pull secrets to service accounts#81
Merged
krancour merged 1 commit intobrigadecore:masterfrom Oct 30, 2020
krancour:image-pull-secrets
Merged
add ability to add image pull secrets to service accounts#81krancour merged 1 commit intobrigadecore:masterfrom krancour:image-pull-secrets
krancour merged 1 commit intobrigadecore:masterfrom
krancour:image-pull-secrets
Conversation
Signed-off-by: Kent Rancourt <kent.rancourt@microsoft.com>
vdice
approved these changes
Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to brigadecore/brigade#1124
@vdice and I determined that it's not ideal for us (and probably not for any Brigade user) to have to explicitly call out the use of a specific image pull
Secretin every job in every script if all you want to do is avoid rate-limiting across the board.A little bit of research determined that if a
Pod'sServiceAccountreferences particular image pullSecrets,thatPodis _automatically decorated to reference the same image pullSecrets`_. ReferenceConveniently, the Brigade chart already, by default, creates
ServiceAccounts for each of its components-- including workers and jobs. This PR allows a user deploying Brigade to optionally add a reference to one or more image pullSecrets to any of theServiceAccounts used by any of the Brigade components-- with special emphasis and documentation for the worker'sServiceAccountsince that is where this capability is most useful.