fix input.js file entries in source maps
#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass inputFilename option to `transformAst`
Member
|
📦 0.5.1 |
pirxpilot
added a commit
to pirxpilot/brfs
that referenced
this pull request
Aug 21, 2018
Pass `inputFilename` to static module to make it insert proper file name into generated source map. Without this change we end up with 'input.js' (which is the default file name) as the basename of affected files in the resulting source maps. see also: browserify/common-shakeify#16
pirxpilot
added a commit
to pirxpilot/brfs
that referenced
this pull request
Aug 21, 2018
Pass `inputFilename` to static module to make it insert proper file name into generated source map. Without this change we end up with 'input.js' (which is the default file name) as the basename of affected files in the resulting source maps. see also: browserify/common-shakeify#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases when common-shakekify is used browserify generates source maps in which some of the file base names are replaced with
input.jstransform-astdefault file name for source maps isinput.jsand before this change we didn't passinputFilenameoption totransformAstfunction.This change seems to help (source maps have real names of the files) although I am not sure exactly why this error does not show up in the tests or example.