Skip to content

feat: use a global symbol for util.promisify.custom #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: use a global symbol for util.promisify.custom #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: use a global symbol for util.promisify.custom 
Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.

This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.

Refs: nodejs/node#31647
Refs: nodejs/node#31672
  • Loading branch information
@ExE-Boss
ExE-Boss committed Feb 8, 2020
commit f89af7de3250ee8a5da72fe6965bc17e7e743b45
5 changes: 4 additions & 1 deletion util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,10 @@ function hasOwnProperty(obj, prop) {
return Object.prototype.hasOwnProperty.call(obj, prop);
}

var kCustomPromisifiedSymbol = typeof Symbol !== 'undefined' ? Symbol('util.promisify.custom') : undefined;
var kCustomPromisifiedSymbol =
typeof Symbol === 'function' && typeof Symbol['for'] === 'function'
? Symbol['for']('nodejs.util.promisify.custom')
: undefined;

exports.promisify = function promisify(original) {
if (typeof original !== 'function')
Expand Down