Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jan 10, 2023

Mend Renovate

This PR contains the following updates:

Package Change
mercurius 10.5.1 -> 11.5.0

GitHub Vulnerability Alerts

CVE-2023-22477

Impact

Any users of Mercurius until version v11.5.0 are subjected to a denial of service attack by sending a malformed packet over WebSocket to /graphql.

Patches

This was patched in https://github.com/mercurius-js/mercurius/pull/940.
The patch was released as v11.5.0 and v8.13.2.

Workarounds

Disable subscriptions.

References

Reported publicly as https://github.com/mercurius-js/mercurius/issues/939.
The same problem was solved in https://github.com/fastify/fastify-websocket/pull/228


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Jan 10, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/mercurius
npm WARN   mercurius@"^11.0.0" from the root project
npm WARN   1 more (@nestjs/mercurius)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer mercurius@"^8.12.0 || ^9.0.0 || ^10.0.0" from @nestjs/[email protected]
npm WARN node_modules/@nestjs/mercurius
npm WARN   @nestjs/mercurius@"^10.1.7" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @nestjs/[email protected]
npm WARN Found: [email protected]
npm WARN node_modules/class-validator
npm WARN   class-validator@"^0.14.0" from the root project
npm WARN   2 more (@nestjs/common, @nestjs/graphql)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peerOptional class-validator@"^0.11.1 || ^0.12.0 || ^0.13.0" from @nestjs/[email protected]
npm WARN node_modules/@nestjs/mapped-types
npm WARN   @nestjs/mapped-types@"1.2.0" from @nestjs/[email protected]
npm WARN   node_modules/@nestjs/graphql
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/class-validator
npm WARN   peerOptional class-validator@"^0.11.1 || ^0.12.0 || ^0.13.0" from @nestjs/[email protected]
npm WARN   node_modules/@nestjs/mapped-types
npm WARN     @nestjs/mapped-types@"1.2.0" from @nestjs/[email protected]
npm WARN     node_modules/@nestjs/graphql
npm notice 
npm notice New major version of npm available! 8.19.3 -> 9.3.0
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.3.0>
npm notice Run `npm install -g [email protected]` to update!
npm notice 
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @nestjs/[email protected]
npm WARN Found: [email protected]
npm WARN node_modules/class-validator
npm WARN   class-validator@"^0.14.0" from the root project
npm WARN   2 more (@nestjs/common, @nestjs/graphql)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peerOptional class-validator@"^0.11.1 || ^0.12.0 || ^0.13.0" from @nestjs/[email protected]
npm WARN node_modules/@nestjs/mapped-types
npm WARN   @nestjs/mapped-types@"1.2.0" from @nestjs/[email protected]
npm WARN   node_modules/@nestjs/graphql
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/class-validator
npm WARN   peerOptional class-validator@"^0.11.1 || ^0.12.0 || ^0.13.0" from @nestjs/[email protected]
npm WARN   node_modules/@nestjs/mapped-types
npm WARN     @nestjs/mapped-types@"1.2.0" from @nestjs/[email protected]
npm WARN     node_modules/@nestjs/graphql
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @nestjs/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/mercurius
npm ERR!   mercurius@"^11.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer mercurius@"^8.12.0 || ^9.0.0 || ^10.0.0" from @nestjs/[email protected]
npm ERR! node_modules/@nestjs/mercurius
npm ERR!   @nestjs/mercurius@"^10.1.7" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/mercurius
npm ERR!   peer mercurius@"^8.12.0 || ^9.0.0 || ^10.0.0" from @nestjs/[email protected]
npm ERR!   node_modules/@nestjs/mercurius
npm ERR!     @nestjs/mercurius@"^10.1.7" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/renovate-cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2023-01-13T16_34_40_513Z-debug-0.log

@bryopsida
Copy link
Owner

bryopsida commented Jan 10, 2023

Will likely have to wait on back port of mercurius-js/mercurius#940 or this nestjs/graphql#2382

@renovate renovate bot force-pushed the renovate/npm-mercurius-vulnerability branch 2 times, most recently from cf86882 to 364cf5d Compare January 12, 2023 00:31
@renovate renovate bot force-pushed the renovate/npm-mercurius-vulnerability branch from 364cf5d to 1a0f2a0 Compare January 13, 2023 16:34
@bryopsida bryopsida closed this Jan 15, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Jan 15, 2023

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (11.5.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/npm-mercurius-vulnerability branch January 15, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants