Conversation
tim-king-code-stuff
approved these changes
Feb 10, 2025
Contributor
tim-king-code-stuff
left a comment
tim-king-code-stuff
left a comment
There was a problem hiding this comment.
I updated inc/template-tags.php and rebuilt js/script.js - the rest looks good
14 tasks
acketon
force-pushed
the
update-foundation-to-3.2.5
branch
from
77f2a80 to
e057abc
Compare
tim-king-code-stuff
approved these changes
Feb 14, 2025
saucyrooster
approved these changes
Feb 18, 2025
| content: "🔧"; | ||
| } | ||
|
|
||
| .lt-ie9:hover .icon-bluesky, .lt-ie9:hover .menu-item [href*="bsky.app"], .menu-item .lt-ie9:hover [href*="bsky.app"] { |
Member
Author
There was a problem hiding this comment.
no, but it's still a part of foundation and the build process so they can added automatically still.
| } | ||
| } | ||
|
|
||
| @media (min-width: 992px) { |
There was a problem hiding this comment.
I don't know if this is possible but these nth-child declarations are very specific and would remove if we can.
Member
Author
There was a problem hiding this comment.
This is being generated in this stylesheet because of a bug fix in Foundation 3.2.4 that fixes this bug: bu-ist/responsive-foundation#269.
You can see the change here:
bu-ist/responsive-foundation@6fd1d3b
The nth-child looks like it is calculated from a sass variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315
Changes proposed in this pull request
Update grunt-browserify to 6.0 to fix missing dependency: fsevents@1.2.9
Update responsive-foundation to
3.2.53.2.6 to get icon and toggle mega menu bug fixes.Required pull requests to merge (usually a pull request on Foundation or a plugin)
Test sites
Clone these sites to your sandbox, and review them briefly. Does everything work as expected?
Review checklist
CHANGELOG.MDwith a brief explanation of the changes in this pull request in the unreleased section.