Skip to content

fix: Avoid dragging downwards or upwards to close the image(especially for the portrait image) when enlarge it to preview on iOS devices. #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −8
Open

fix: Avoid dragging downwards or upwards to close the image(especially for the portrait image) when enlarge it to preview on iOS devices. #100

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
150e657
fix: Avoid dragging downwards or upwards to close the image(especiall…
janlionly May 27, 2021
56ebb45
fix: If there's only one image, avoid dragging the image to get back …
janlionly May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Avoid dragging downwards or upwards to close the image(especiall… 
…y for the portrait image) when enlarge it to preview.
  • Loading branch information
@janlionly
janlionly committed May 27, 2021
commit 150e657f5cfa0488b260b615d237ee3d7e191534
4 changes: 3 additions & 1 deletion BFRImageViewController/BFRImageContainerViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,9 @@ - (void)handleHiResImageDownloaded:(NSNotification *)note {
// If we have more than one image, this will cancel out dragging horizontally to make it easy to navigate between images
- (BOOL)gestureRecognizerShouldBegin:(UIGestureRecognizer *)gestureRecognizer {
CGPoint velocity = [(UIPanGestureRecognizer *)gestureRecognizer velocityInView:self.scrollView];
if (self.scrollView.zoomScale > 1) {
return NO;
}
return fabs(velocity.y) > fabs(velocity.x);
}

Expand Down Expand Up @@ -370,7 +373,6 @@ - (void)handleDrag:(UIPanGestureRecognizer *)recognizer {
[self.animator removeAllBehaviors];
self.activeAssetView.userInteractionEnabled = NO;
self.scrollView.userInteractionEnabled = NO;

UIGravityBehavior *exitGravity = [[UIGravityBehavior alloc] initWithItems:@[self.activeAssetView]];
if (CGRectContainsPoint(closeTopThreshhold, location)) {
exitGravity.gravityDirection = CGVectorMake(0.0, -1.0);
Expand Down