Skip to content

Dispatcher::fire is effectively removed as of 5.8 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maherelgamil merged 2 commits into from
Apr 30, 2019
Merged

Dispatcher::fire is effectively removed as of 5.8 #19

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f005f6
Dispatcher::fire is effectively removed as of 5.8
greut Mar 1, 2019
c2f2137
readme: update to 5.8
greut Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Dispatcher::fire is effectively removed as of 5.8 
Signed-off-by: Yoan Blanc <[email protected]>
  • Loading branch information
@greut
greut committed Mar 1, 2019
commit 3f005f67bf7c2c26f25d6493ecbaccecb65feff9
10 changes: 5 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
"editor"
],
"require": {
"illuminate/support": "^5.1",
"illuminate/filesystem": "^5.1",
"illuminate/events": "^5.1",
"illuminate/container": "^5.1",
"illuminate/contracts": "^5.1",
"illuminate/support": "^5.4",
"illuminate/filesystem": "^5.4",
"illuminate/events": "^5.4",
"illuminate/container": "^5.4",
"illuminate/contracts": "^5.4",
"erusev/parsedown": "^1.6",
"erusev/parsedown-extra": "0.7.*"
},
Expand Down
8 changes: 4 additions & 4 deletions src/Laradown.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,12 @@ protected function element(array $Element)
public function convert($markdown)
{
// Fire converting event
$this->getContainer('events')->fire('laradown.entity.converting');
$this->getContainer('events')->dispatch('laradown.entity.converting');

$text = $this->text($markdown);

// Fire converted event
$this->getContainer('events')->fire('laradown.entity.converted');
$this->getContainer('events')->dispatch('laradown.entity.converted');

return $text;
}
Expand All @@ -124,7 +124,7 @@ public function render($markdown)
public function collect()
{
// Fire collecting event
$this->getContainer('events')->fire('laradown.entity.collecting');
$this->getContainer('events')->dispatch('laradown.entity.collecting');

// Make indicator true
$this->collect_indicator = true;
Expand All @@ -145,7 +145,7 @@ public function endCollect()
$markdown = ob_get_clean();

// Fire collected event
$this->getContainer('events')->fire('laradown.entity.collected');
$this->getContainer('events')->dispatch('laradown.entity.collected');

// Convert the markdown content to html
return $this->convert($markdown);
Expand Down