Skip to content

Conversation

@artur-ptaszek-mck
Copy link

Thanks for contributing to react-virtualized!

Before submitting a pull request, please complete the following checklist:

  • The existing test suites (npm test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (yarn run prettier).
  • Run the Flow typechecks (yarn run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

  • Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
  • Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

Since update to React 19-rc.1 (which is part of the latest NextJS 15) these functionalities started to fail (at least in the app we have). These changes helped avoid usages of findDOMNode that has been removed as well as defaultProps which didn't have an effect "from outside" all these settings were empty. Cannot say it's complex support for the latest React, but it's a great start.

@giorgio-zamparelli
Copy link

React 19.0.0 is stable and would be nice to support it:
https://react.dev/blog/2024/04/25/react-19-upgrade-guide

@cas8180
Copy link

cas8180 commented Dec 7, 2024

React 19.0.0 is stable and would be nice to support it: https://react.dev/blog/2024/04/25/react-19-upgrade-guide

Please! Really need this

@cas8180
Copy link

cas8180 commented Dec 22, 2024

For the love of god and maybe an early xmas gift can someone just come in and hit the merge button?

@mpmua
Copy link

mpmua commented Dec 23, 2024

For the love of god and maybe an early xmas gift can someone just come in and hit the merge button?

@bvaughn any chance this can be merged?

@Amitabh1989
Copy link

The merge is blocked. Please OKAY this for merge. The world needs this fix yesterday!

@bvaughn
Copy link
Owner

bvaughn commented Jan 20, 2025

Thanks for putting this together. #1866 seemed a bit more comprehensive at a quick glance so I merged it. Will give you both props in the release notes thouhg.

@bvaughn bvaughn closed this Jan 20, 2025
@bvaughn
Copy link
Owner

bvaughn commented Jan 20, 2025

Updated published as v9.22.5 v9.22.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants