Skip to content

Conversation

@artur-ptaszek-mck
Copy link

After releasing version 9.22.6 this PR has been merged #1866, but my changes included additional changes for default props.

Thanks for contributing to react-virtualized!

Before submitting a pull request, please complete the following checklist:

  • The existing test suites (npm test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (yarn run prettier).
  • Run the Flow typechecks (yarn run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

  • Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
  • Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

@karlismelderis-mckinsey
Copy link

karlismelderis-mckinsey commented Jan 30, 2025

@bvaughn can you please get this merged and released? 🙏

@hervinder
Copy link

Hey @artur-ptaszek-mck,
Thanks for your contributions to react-virtualized!

I recently upgraded my app to React 19 and also updated the react-virtualized package to version 9.22.6. However, I'm encountering the error:
TypeError: headerRenderer is not a function at Table2._createHeader.

Does this PR address this issue? If so, do we have a timeline for when it will be merged?

@ryxxuk
Copy link

ryxxuk commented Feb 24, 2025

Encountering the same issue, when can this be merged?

@github-actions github-actions bot added the Stale label Mar 25, 2025
@github-actions github-actions bot closed this Mar 25, 2025
@jitendra-bhandure
Copy link

@bvaughn Please merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants