Repository navigation
red-check-skips-deleted-test-files/1: The red check and the push gate give the runner only files the tests commit leaves in place - #984
Merged
Conversation
…tests commit leaves in place The tests come first and fail until the implementation. The unit `di-repo-tidy/1` failed its red check three times with "nothing failed at the tests commit". Unit: red-check-skips-deleted-test-files/1
…tests commit leaves in place With this in, the tests of the previous commit pass. The unit `di-repo-tidy/1` failed its red check three times with "nothing failed at the tests commit". Unit: red-check-skips-deleted-test-files/1
…ests commit leaves in place (checks, round 1) Unit: red-check-skips-deleted-test-files/1
…ests commit leaves in place (review round 1) Unit: red-check-skips-deleted-test-files/1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start here
Already verified by the pipeline
Review tier:
light— the planned estimate is lightWhy
The unit
di-repo-tidy/1failed its red check three times with "nothing failed at the tests commit". Its tests commit deletedtests/integration/test_date_order_test_finds_scripts.pyand addedtests/extraction/test_date_order_finds_scripts.py. The red check lists the files of the tests commit withgit show --name-only, which names a deleted file as well as an added one. Both runs of the red command (the one narrowed to the changed tests and the retry with the files whole) named the deleted path.… The full reason is in
openspec/changes/red-check-skips-deleted-test-files/proposal.md.What this pull request does
The red check and the push gate no longer give the test runner a test file that the tests commit deleted, or the old path of a renamed one.
git ls-treeoutput, so unusual path characters are compared exactly.Based on
main, with nothing unmerged beneath it — ready to merge whenever the checks look right.Unit
red-check-skips-deleted-test-files/1of change red-check-skips-deleted-test-files, task group(s) 1.Spec:
openspec/changes/red-check-skips-deleted-test-files/in the planning repo.Assumptions
This unit assumes nothing unmerged: everything it builds on is already in
main.Verification
This is a unit-test unit: everything it needs is fakes, fixtures or throwaway containers, so GitHub Actions runs the whole of it. No e2e-test run was required.
Left for later
Approved, with these recorded rather than blocking:
_files_ofin pipeline/gate.py still lists files withgit ls-treewithout-z, so a path with an unusual character is quoted there while_left_in_placereads it raw. The builder left it alone because it predates this change and affects commit classification. It could be aligned in a later unit.How this was built
Tests were committed first and seen to fail before any implementation existed; the commit order is checked mechanically; lint, formatting and types pass at the tip.
Opened by the spec-driven pipeline. The build agent never merges. The pipeline merges only
a unit review classified
autoand policy allowed; a person merges any other, after checkingthe stack order above.