Repository navigation
js-red-check-accepts-a-thrown-error/1: The Node red check accepts a failing test with a plain Error - #985
Merged
Conversation
The tests come first and fail until the implementation. The Node profile judges a tests commit red only when a failing test's JUnit `type` is `AssertionError`, or its message is exactly `not implemented`. Unit: js-red-check-accepts-a-thrown-error/1
With this in, the tests of the previous commit pass. The Node profile judges a tests commit red only when a failing test's JUnit `type` is `AssertionError`, or its message is exactly `not implemented`. Unit: js-red-check-accepts-a-thrown-error/1
Unit: js-red-check-accepts-a-thrown-error/1
…view round 1) Unit: js-red-check-accepts-a-thrown-error/1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start here
Already verified by the pipeline
Review tier:
light— the reviewer classified it lightWhy
The Node profile judges a tests commit red only when a failing test's JUnit
typeisAssertionError, or its message is exactlynot implemented. A test that calls code which throws a plainErrorof its own is rejected as "not one we recognise as 'the behaviour isn't there yet'".loader-knows-the-usage-dataset/1hit it: its three new loader tests failed correctly, withDataset "usage" is not a report datasetthrown by the loader, and the red check rejected them three times. The unit only pa… The full reason is in
openspec/changes/js-red-check-accepts-a-thrown-error/proposal.md.What this pull request does
The Node toolchain's red check now accepts a test that fails because the code under test throws a plain Error. It still refuses TypeError, ReferenceError and SyntaxError failures and names the type in the reason.
interpret_redin the Node profile treats a failure of typeErroras red, the same as anAssertionError.TypeError,ReferenceErrororSyntaxErroris rejected with a reason that names the type and says it points to a missing name or a broken test, not missing behaviour.Based on
main, with nothing unmerged beneath it — ready to merge whenever the checks look right.Unit
js-red-check-accepts-a-thrown-error/1of change js-red-check-accepts-a-thrown-error, task group(s) 1.Spec:
openspec/changes/js-red-check-accepts-a-thrown-error/in the planning repo.Assumptions
This unit assumes nothing unmerged: everything it builds on is already in
main.Verification
This is a unit-test unit: everything it needs is fakes, fixtures or throwaway containers, so GitHub Actions runs the whole of it. No e2e-test run was required.
How this was built
Tests were committed first and seen to fail before any implementation existed; the commit order is checked mechanically; lint, formatting and types pass at the tip.
Opened by the spec-driven pipeline. The build agent never merges. The pipeline merges only
a unit review classified
autoand policy allowed; a person merges any other, after checkingthe stack order above.