Repository navigation
restack-regenerates-generated-files/1: The generated setting in repos config, generated_file_patterns and the doctor check - #986
Merged
Conversation
The tests come first and fail until the implementation. A unit that edits `agent-assessment/web` also commits the build output (`src/server/web/assets/*-<hash>.js`, `src/server/web/index.html`, `src/report/template.html`). Unit: restack-regenerates-generated-files/1
With this in, the tests of the previous commit pass. A unit that edits `agent-assessment/web` also commits the build output (`src/server/web/assets/*-<hash>.js`, `src/server/web/index.html`, `src/report/template.html`). Unit: restack-regenerates-generated-files/1
… and the doctor check (review round 1) Unit: restack-regenerates-generated-files/1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start here
Already verified by the pipeline
Review tier:
light— the planned estimate is lightWhy
This pull request builds part of change restack-regenerates-generated-files; this is the change's reason.
A unit that edits
agent-assessment/webalso commits the build output (src/server/web/assets/*-<hash>.js,src/server/web/index.html,src/report/template.html). The asset names carry a content hash, so any two units that rebuild them conflict on every file: renamed on both sides, deleted by one and added by the other, or both deleted. The restack ofreport-views-usage-and-coverage/4hit this and failed withNo such file or directoryon a path both sides had deleted, because the conflict han… The full reason is in
openspec/changes/restack-regenerates-generated-files/proposal.md.What this pull request does
Adds a per-repo
generatedsetting to abk.yaml that declares build output (the paths it covers, the command that rebuilds it, and the directory to run it in), and teaches the size rule and the doctor about it.generatedentries, each withpaths, acommandand an optionalcwdthat defaults to the repository root.generatedentry count as generated files for the size rule, beside the existing limits and lock-file patterns.abk doctorlists eachgeneratedentry. It warns when a pattern matches no tracked file (judged with the same matcher the size rule uses) and when the entry's command cannot be found.Based on
main, with nothing unmerged beneath it — ready to merge whenever the checks look right.Unit
restack-regenerates-generated-files/1of change restack-regenerates-generated-files, task group(s) 1.Spec:
openspec/changes/restack-regenerates-generated-files/in the planning repo.Assumptions
This unit assumes nothing unmerged: everything it builds on is already in
main.Verification
This is a unit-test unit: everything it needs is fakes, fixtures or throwaway containers, so GitHub Actions runs the whole of it. No e2e-test run was required.
Left for later
Approved, with these recorded rather than blocking:
generatedentry like*.jsmakes the doctor (and the size rule) treat every tracked .js anywhere as covered. That is consistent with the size rule today, but the docs for thegeneratedsetting should say that a slash-free pattern matches by file name anywhere in the repository.How this was built
Tests were committed first and seen to fail before any implementation existed; the commit order is checked mechanically; lint, formatting and types pass at the tip.
Opened by the spec-driven pipeline. The build agent never merges. The pipeline merges only
a unit review classified
autoand policy allowed; a person merges any other, after checkingthe stack order above.