Repository navigation
tests-step-takes-its-own-leftover-work/1: A tests step over its own leftover tests is not judged as writing nothing - #995
Merged
Conversation
…ng nothing The tests come first and fail until the implementation. On 2026-11-17 the units `restack-regenerates-generated-files/3` and `report-views-usage-and-coverage/7` failed at their tests step with "the tests step wrote no test, twice: the tree is unchanged". Unit: tests-step-takes-its-own-leftover-work/1
…ng nothing With this in, the tests of the previous commit pass. On 2026-11-17 the units `restack-regenerates-generated-files/3` and `report-views-usage-and-coverage/7` failed at their tests step with "the tests step wrote no test, twice: the tree is unchanged". Unit: tests-step-takes-its-own-leftover-work/1
…g nothing (review round 1) Unit: tests-step-takes-its-own-leftover-work/1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start here
Already verified by the pipeline
Review tier:
light— the planned estimate is lightWhy
On 2026-11-17 the units
restack-regenerates-generated-files/3andreport-views-usage-and-coverage/7failed at their tests step with "the tests step wrote no test, twice: the tree is unchanged". For the first, the tests were in the tree: a docs test that an earlier run of the same step had written and left staged, and the pipeline resumed over it ("resuming over uncommitted work in 1 file(s)"). The agent reviewed the file, kept it as right and wrote nothing more. The tests step took a digest of… The full reason is in
openspec/changes/tests-step-takes-its-own-leftover-work/proposal.md.What this pull request does
A tests step that was killed and then resumed over its own uncommitted test or document files now keeps that work, instead of being judged as having written nothing.
BuildPath.wrote_nothingtreats a test or document file left over in the tree when the step resumed as written work. This holds even for a group that requires tests, so the step goes on to the stub checks and commits the file.BuildPath._is_test, replaces three inline test-path lambdas: in the restack kinds, the outside-commits note andwrote_nothing.test:commit.Based on
main, with nothing unmerged beneath it — ready to merge whenever the checks look right.Unit
tests-step-takes-its-own-leftover-work/1of change tests-step-takes-its-own-leftover-work, task group(s) 1.Spec:
openspec/changes/tests-step-takes-its-own-leftover-work/in the planning repo.Assumptions
This unit assumes nothing unmerged: everything it builds on is already in
main.Verification
This is a unit-test unit: everything it needs is fakes, fixtures or throwaway containers, so GitHub Actions runs the whole of it. No e2e-test run was required.
How this was built
Tests were committed first and seen to fail before any implementation existed; the commit order is checked mechanically; lint, formatting and types pass at the tip.
Opened by the spec-driven pipeline. The build agent never merges. The pipeline merges only
a unit review classified
autoand policy allowed; a person merges any other, after checkingthe stack order above.