Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Conversation

@brendandburns
Copy link

There's discussion that is relevant here:

bytecodealliance/wasmtime#5678

@brendandburns
Copy link

I have sent a PR here to the wasi-http repository:

WebAssembly/wasi-http#2

@lukewagner
Copy link

lukewagner commented Feb 17, 2023

Thanks for filing this and sorry for the race condition and taking so long to get a PR up! I'm happy to discuss more and compare the different approaches in wasi-http/#3 if that sounds good to you.

@eduardomourar
Copy link
Collaborator Author

Thanks. I am glad to get the discussion started. Just to be clear that my main goal is the outbound HTTP request. So I believe it would be nice to get that fleshed out first (basically because it is simpler) in order to have this PR merged. Don't you agree?

@guest271314
Copy link

Don't forget about local server development using HTTPS and WebSocket, or QuickJS and txiki.js which has wasm3 support out of the box. Node.js is not the only JavaScript runtime. Folks are using QuickJS and txiki.js to, among other reasons, get away from the 40MB V8 minimal runtime load.

@pchickey
Copy link
Collaborator

@eduardomourar @brendandburns et al: from various discussions spread around many repos it sounds like there is rough alignment in the Bytecode Alliance to start implementing WebAssembly/wasi-http#3, see how it shakes out, and feed whatever we learn back into the spec, just as we're doing with other foundational wasi proposals in this repo.

There is still lots of design to work out, but I think there is enough known at this point to start dividing up and conquering an actual implementation of wasi-http PR#3. This PR is a great concrete step in the right direction, but there is still lots to iterate on so that it meets with the standards proposal, which is considerably more complex.

I'd like to get together a (small) set of bytecode alliance contributors who can dedicate time over the next month to hack on this. Lets have a meeting next week to find alignment, and do some project planning so we don't step on each others toes too much. Please let me know who to invite and some available meeting times on zulip, or email phickey at fastly.

@eduardomourar eduardomourar changed the title feat: wasi http experimental feat: wasi outbound http experimental Mar 7, 2023
@eduardomourar
Copy link
Collaborator Author

@pchickey, as discussed I will leave this open here until we have the basic scaffolding in place for the wasi-http definition. Then, @brendandburns and I will start to implement each trait in the host focusing on the outgoing aspect first.

@eduardomourar eduardomourar changed the title feat: wasi outbound http experimental feat: wasi outgoing http experimental Mar 7, 2023
@eduardomourar eduardomourar changed the title feat: wasi outgoing http experimental feat: add basic scaffolding for wasi http Mar 14, 2023
@eduardomourar eduardomourar marked this pull request as ready for review March 14, 2023 00:53
@eduardomourar eduardomourar requested a review from pchickey March 14, 2023 01:08
Copy link
Collaborator

@pchickey pchickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some small comments, and then one significant chunk of stubs is missing

@eduardomourar
Copy link
Collaborator Author

Just to be clear that the rust host has been implemented for wasmtime in this PR: bytecodealliance/wasmtime#5929

@eduardomourar eduardomourar merged commit d826fab into bytecodealliance:main Mar 17, 2023
@eduardomourar eduardomourar deleted the feat/wasi-http-experimental branch March 17, 2023 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants