Skip to content

Refactor the internals of Func to remove layers of indirection #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 9 commits into from
Mar 19, 2020
Merged

Refactor the internals of Func to remove layers of indirection #1363

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f5fe9b7
Remove `WrappedCallable` indirection
alexcrichton Mar 18, 2020
1351004
Remove the `Callable` trait
alexcrichton Mar 19, 2020
dca57d9
Add a test for an already-fixed issue
alexcrichton Mar 19, 2020
caded3c
rustfmt
alexcrichton Mar 19, 2020
af3dac1
Update more locations for `Callable`
alexcrichton Mar 19, 2020
fa0e2b2
rustfmt
alexcrichton Mar 19, 2020
5b68a72
Remove a stray leading borrow
alexcrichton Mar 19, 2020
0689e8a
Review feedback
alexcrichton Mar 19, 2020
2ed2164
Remove unneeded `wasmtime_call_trampoline` shim
alexcrichton Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a test for an already-fixed issue 
Closes #849
  • Loading branch information
@alexcrichton
alexcrichton committed Mar 19, 2020
commit dca57d94795e962ba69ffa8468e00efc36db988f
10 changes: 10 additions & 0 deletions crates/api/tests/func.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,3 +385,13 @@ fn caller_memory() -> anyhow::Result<()> {
Instance::new(&module, &[f.into()])?;
Ok(())
}

#[test]
fn func_write_nothing() -> anyhow::Result<()> {
let store = Store::default();
let ty = FuncType::new(Box::new([]), Box::new([ValType::I32]));
let f = Func::new(&store, ty, |_, _, _| Ok(()));
let err = f.call(&[]).unwrap_err();
assert_eq!(err.message(), "function attempted to return an incompatible value");
Ok(())
}