Skip to content

wasmtime: Implement fast Wasm stack walking #4431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fitzgen merged 46 commits into from
Jul 28, 2022
Merged

wasmtime: Implement fast Wasm stack walking #4431

Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
7eca005
Always preserve frame pointers in Wasmtime
fitzgen Jul 19, 2022
8a6a0f1
wasmtime: Implement fast Wasm stack walking
fitzgen Jun 30, 2022
381627e
Add s390x support for frame pointer-based stack walking
uweigand Jul 20, 2022
d634136
wasmtime: Allow `Caller::get_export` to get all exports
fitzgen Jul 12, 2022
abfb54a
fuzzing: Add a fuzz target to check that our stack traces are correct
fitzgen Jul 12, 2022
2819a3f
Remove VM offsets for `VMHostFuncContext` since it isn't used by JIT …
fitzgen Jul 21, 2022
2cbaa37
Add doc comment with stack walking implementation notes
fitzgen Jul 21, 2022
d5e7881
Document the extra state that can be passed to `wasmtime_runtime::Bac…
fitzgen Jul 21, 2022
cafcdd7
Add extensive comments for stack walking function
fitzgen Jul 21, 2022
8275b13
Factor architecture-specific bits of stack walking out into modules
fitzgen Jul 21, 2022
70af149
Initialize store-related fields in a vmctx to null when there is no s…
fitzgen Jul 21, 2022
a8ed50d
Use `set_callee` instead of manually setting the vmctx field
fitzgen Jul 21, 2022
52089b0
Use a more informative compile error message for unsupported architec…
fitzgen Jul 21, 2022
5f76da6
Document unsafety of `prepare_host_to_wasm_trampoline`
fitzgen Jul 21, 2022
43e8d00
Use `bti c` instead of `hint #34` in inline aarch64 assembly
fitzgen Jul 21, 2022
d6689de
Remove outdated TODO comment
fitzgen Jul 21, 2022
5b75b0d
Remove setting of `last_wasm_exit_fp` in `set_jit_trap`
fitzgen Jul 21, 2022
21d962a
Only set the stack limit once, in the face of re-entrancy into Wasm
fitzgen Jul 21, 2022
54d028d
Add comments for s390x-specific stack walking bits
fitzgen Jul 21, 2022
2536799
Use the helper macro for all libcalls
fitzgen Jul 25, 2022
1c873d3
Use the `asm_sym!` macro in Wasm-to-libcall trampolines
fitzgen Jul 25, 2022
9baa4c9
wasmtime: add size and align to `externref` assertion error message
fitzgen Jul 25, 2022
7301c5f
Extend the `stacks` fuzzer to have host frames in between Wasm frames
fitzgen Jul 25, 2022
836b667
Add documentation for aarch64-specific backtrace helpers
fitzgen Jul 26, 2022
aee1f23
Clarify that we only support little-endian aarch64 in trampoline comment
fitzgen Jul 26, 2022
9388c6a
Use `.machine z13` in s390x assembly file
fitzgen Jul 26, 2022
cca2eab
Fix aarch64 build
fitzgen Jul 26, 2022
4ccf2d0
Fix macOS build
fitzgen Jul 26, 2022
6ce870b
Document the `asm_sym!` macro
fitzgen Jul 26, 2022
8e2650e
Add windows support to the `wasmtime-asm-macros` crate
fitzgen Jul 26, 2022
3421595
Add windows support to host<--->Wasm trampolines
fitzgen Jul 26, 2022
1e8836f
Fix trap handler build on windows
fitzgen Jul 26, 2022
f5fa742
Run `rustfmt` on s390x trampoline source file
fitzgen Jul 26, 2022
4b7aed4
Temporarily disable some assertions about a trap's backtrace in the c…
fitzgen Jul 26, 2022
f983960
Refactor libcall definitions with less macros
alexcrichton Jul 27, 2022
0c3d3c8
Use `VMOpaqueContext::from_vm_host_func_context` in `VMHostFuncContex…
fitzgen Jul 27, 2022
2cb3211
Move `backtrace` module to be submodule of `traphandlers`
fitzgen Jul 27, 2022
8e81497
Fix macOS aarch64 build
fitzgen Jul 27, 2022
7e0f1ca
Use "i64" instead of "word" in aarch64-specific file
fitzgen Jul 27, 2022
a5a5a88
Save/restore entry SP and exit FP/return pointer in the face of panic…
fitzgen Jul 27, 2022
0cd3d32
Put "typed" vs "untyped" in the same position of call benchmark names
fitzgen Jul 27, 2022
e8fa1c0
Fix stacks test case generator build for new `wasm-encoder`
fitzgen Jul 28, 2022
3b2cc72
Fix build for s390x
fitzgen Jul 28, 2022
4510388
Expand libcalls in s390x asm
fitzgen Jul 28, 2022
1a302f1
Disable more parts of component tests now that backtrace assertions a…
fitzgen Jul 28, 2022
a8780c6
Remove assertion that can maybe fail on s390x
fitzgen Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Put "typed" vs "untyped" in the same position of call benchmark names 
Regardless if we are doing wasm-to-host or host-to-wasm
  • Loading branch information
@fitzgen
fitzgen committed Jul 27, 2022
commit 0cd3d3232c6af46b987764b8d0d9e0a39a255be5
4 changes: 2 additions & 2 deletions benches/call.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ fn wasm_to_host(c: &mut Criterion) {
desc: &str,
is_async: IsAsync,
) {
group.bench_function(&format!("wasm-to-host - nop - {}", desc), |b| {
group.bench_function(&format!("wasm-to-host - {} - nop", desc), |b| {
let run = instance
.get_typed_func::<u64, (), _>(&mut *store, "run-nop")
.unwrap();
Expand All @@ -383,7 +383,7 @@ fn wasm_to_host(c: &mut Criterion) {
})
});
group.bench_function(
&format!("wasm-to-host - nop-params-and-results - {}", desc),
&format!("wasm-to-host - {} - nop-params-and-results", desc),
|b| {
let run = instance
.get_typed_func::<u64, (), _>(&mut *store, "run-nop-params-and-results")
Expand Down