Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fuzz: move control plane into emit state
Co-authored-by: Falk Zwimpfer <[email protected]>
Co-authored-by: Moritz Waser <[email protected]>
  • Loading branch information
3 people committed Apr 3, 2023
commit a0f379b167a64c53eeb11ecfa7606cd662b7f38d
113 changes: 54 additions & 59 deletions cranelift/codegen/src/isa/aarch64/inst/emit.rs

Large diffs are not rendered by default.

12 changes: 2 additions & 10 deletions cranelift/codegen/src/isa/aarch64/inst/emit_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ use crate::settings;

use alloc::boxed::Box;
use alloc::vec::Vec;
use cranelift_control::ControlPlane;

#[cfg(test)]
fn simm9_zero() -> SImm9 {
Expand Down Expand Up @@ -7810,16 +7809,9 @@ fn test_aarch64_binemit() {
insn.print_with_state(&mut EmitState::default(), &mut AllocationConsumer::new(&[]));
assert_eq!(expected_printing, actual_printing);

let ctrl_plane = &mut ControlPlane::default();
let mut buffer = MachBuffer::new();
insn.emit(
&[],
&mut buffer,
&emit_info,
&mut Default::default(),
ctrl_plane,
);
let buffer = buffer.finish(ctrl_plane);
insn.emit(&[], &mut buffer, &emit_info, &mut Default::default());
let buffer = buffer.finish(&mut Default::default());
let actual_encoding = &buffer.stringify_code_bytes();
assert_eq!(expected_encoding, actual_encoding);
}
Expand Down
5 changes: 2 additions & 3 deletions cranelift/codegen/src/isa/aarch64/inst/unwind/systemv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ mod tests {
use crate::isa::{lookup, CallConv};
use crate::settings::{builder, Flags};
use crate::Context;
use cranelift_control::ControlPlane;
use gimli::write::Address;
use std::str::FromStr;
use target_lexicon::triple;
Expand All @@ -93,7 +92,7 @@ mod tests {
));

let code = context
.compile(&*isa, &mut ControlPlane::default())
.compile(&*isa, &mut Default::default())
.expect("expected compilation");

let fde = match code
Expand Down Expand Up @@ -134,7 +133,7 @@ mod tests {
let mut context = Context::for_function(create_multi_return_function(CallConv::SystemV));

let code = context
.compile(&*isa, &mut ControlPlane::default())
.compile(&*isa, &mut Default::default())
.expect("expected compilation");

let fde = match code
Expand Down
12 changes: 3 additions & 9 deletions cranelift/codegen/src/isa/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -100,15 +100,9 @@ pub fn lookup(triple: Triple) -> Result<Builder, LookupError> {
Architecture::X86_64 => {
isa_builder!(x64, (feature = "x86"), triple)
}
Architecture::Aarch64 { .. } => {
isa_builder!(aarch64, (feature = "arm64"), triple)
}
Architecture::S390x { .. } => {
isa_builder!(s390x, (feature = "s390x"), triple)
}
Architecture::Riscv64 { .. } => {
isa_builder!(riscv64, (feature = "riscv64"), triple)
}
Architecture::Aarch64 { .. } => isa_builder!(aarch64, (feature = "arm64"), triple),
Architecture::S390x { .. } => isa_builder!(s390x, (feature = "s390x"), triple),
Architecture::Riscv64 { .. } => isa_builder!(riscv64, (feature = "riscv64"), triple),
_ => Err(LookupError::Unsupported),
}
}
Expand Down
Loading