Skip to content

Make streams owned by request/response that they are tied to. #6228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pchickey merged 6 commits into from
Apr 21, 2023
Merged

Make streams owned by request/response that they are tied to. #6228

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c7b3f25
Make streams owned by request/response that they are tied to.
brendandburns Apr 18, 2023
a72d8e0
Address comments, fix tests.
brendandburns Apr 19, 2023
14b25d2
Address comment.
brendandburns Apr 20, 2023
22a2dd5
Update crates/wasi-http/src/streams_impl.rs
brendandburns Apr 20, 2023
bf2c3ba
Switch to BytesMut
brendandburns Apr 20, 2023
b855a4b
Merge branch 'ptr' of https://github.com/brendandburns/wasmtime into ptr
brendandburns Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address comment.
  • Loading branch information
@brendandburns
brendandburns committed Apr 20, 2023
commit 14b25d22d65b645f9c708caabf5488c9ae3c5d5d
8 changes: 1 addition & 7 deletions crates/wasi-http/src/http_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,13 +223,7 @@ impl WasiHttp {
}
response.body = self.streams_id_base;
self.streams_id_base = self.streams_id_base + 1;
self.streams.insert(
response.body,
Stream {
closed: false,
data: buf.freeze(),
},
);
self.streams.insert(response.body, buf.freeze().into());
self.responses.insert(response_id, response);
Ok(response_id)
}
Expand Down