Skip to content

Rename the wasm32-wasi target to wasm32-wasip1 #8867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexcrichton merged 1 commit into from
Jul 25, 2024
Merged

Rename the wasm32-wasi target to wasm32-wasip1 #8867

alexcrichton merged 1 commit into from
Jul 25, 2024

Conversation

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Jun 24, 2024

This rename is happening in upstream Rust and should be in enough places now.

prtest:full

@alexcrichton alexcrichton requested review from a team as code owners June 24, 2024 15:29
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team June 24, 2024 15:29
@alexcrichton alexcrichton marked this pull request as draft June 24, 2024 15:46
@alexcrichton
Copy link
Member Author

alexcrichton commented Jun 24, 2024

Ok a full CI run confirms a fear I had which is that our current MSRV of 1.77.0 doesn't support wasm32-wasip1. I'll put this PR on ice and try to re-land once Rust 1.80 is released.

@github-actions github-actions bot added wasi Issues pertaining to WASI wasmtime:docs Issues related to Wasmtime's documentation labels Jun 24, 2024
@fitzgen fitzgen removed their request for review June 25, 2024 17:05
@elliottt elliottt removed the request for review from a team July 2, 2024 17:30
@alexcrichton
Rename the wasm32-wasi target to wasm32-wasip1
ef4693c 
This rename is happening in upstream Rust and should be in enough places
now.

prtest:full
@alexcrichton alexcrichton marked this pull request as ready for review July 25, 2024 16:20
@alexcrichton
Copy link
Member Author

alexcrichton commented Jul 25, 2024

Ok with our MSRV now bumped I think this should be ready to land

@alexcrichton alexcrichton added this pull request to the merge queue Jul 25, 2024
@abrown
Copy link
Member

abrown commented Jul 25, 2024

This made me think maybe we want to update this naming in wasi-sdk: WebAssembly/wasi-sdk#459?

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2024
@alexcrichton alexcrichton added this pull request to the merge queue Jul 25, 2024
Merged via the queue into bytecodealliance:main with commit 05095c1 Jul 25, 2024
@alexcrichton alexcrichton deleted the rename-wasi-target branch July 25, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pchickey pchickey pchickey approved these changes

@abrown abrown abrown approved these changes

Assignees

No one assigned

Labels

wasi Issues pertaining to WASI wasmtime:docs Issues related to Wasmtime's documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcrichton @abrown @pchickey