some cleanup

command/upgrade/logger.ts

@@ -27,11 +27,7 @@ export function createLogger({ spinner, verbose }: LoggerOptions): Logger {
     log: (...args: Array<unknown>): void => {
       verbose && write("log", ...args);
     },
-    info: (...args: Array<unknown>): void => {
-      write("info", ...args);
-    },
-    error: (...args: Array<unknown>): void => {
-      write("error", ...args);
-    },
+    info: (...args: Array<unknown>): void => write("info", ...args),
+    error: (...args: Array<unknown>): void => write("error", ...args),
   };
 }

command/upgrade/provider.ts

@@ -23,15 +23,15 @@ export abstract class Provider {
 
   abstract getVersions(name: string): Promise<Versions>;
 
-  abstract getRepositoryUrl(name: string): string;
+  abstract getRepositoryUrl(name: string, version?: string): string;
 
   abstract getRegistryUrl(name: string, version: string): string;
 
   getSpecifier(name: string, version: string, defaultMain?: string): string {
     return `${this.getRegistryUrl(name, version)}${this.getMain(defaultMain)}`;
   }
 
-  private getMain(defaultMain?: string) {
+  private getMain(defaultMain?: string): string {
     const main = this.main ?? defaultMain;
     return main ? `/${main}` : "";
   }

command/upgrade/provider/deno_land.ts

@@ -30,8 +30,11 @@ export class DenoLandProvider extends Provider {
     return await response.json();
   }
 
-  getRepositoryUrl(name: string): string {
-    return new URL(`${this.moduleName ?? name}/`, this.repositoryUrl).href;
+  getRepositoryUrl(name: string, version?: string): string {
+    return new URL(
+      `${this.moduleName ?? name}${version ? `@${version}` : ""}`,
+      this.repositoryUrl,
+    ).href;
   }
 
   getRegistryUrl(name: string, version: string): string {

command/upgrade/provider/github.ts

@@ -62,8 +62,11 @@ export class GithubProvider extends Provider {
     };
   }
 
-  getRepositoryUrl(_name: string): string {
-    return new URL(`${this.repositoryName}/`, this.repositoryUrl).href;
+  getRepositoryUrl(_name: string, version?: string): string {
+    return new URL(
+      `${this.repositoryName}${version ? `/releases/tag/${version}` : ""}`,
+      this.repositoryUrl,
+    ).href;
   }
 
   getRegistryUrl(_name: string, version: string): string {

command/upgrade/provider/jsr.ts

@@ -62,9 +62,11 @@ export class JsrProvider extends Provider {
     };
   }
 
-  getRepositoryUrl(name: string): string {
+  getRepositoryUrl(name: string, version?: Semver): string {
     return new URL(
-      `@${this.packageScope}/${this.packageName ?? name}`,
+      `@${this.packageScope}/${this.packageName ?? name}${
+        version ? `@${version}` : ""
+      }`,
       this.repositoryUrl,
     ).href;
   }

command/upgrade/provider/nest_land.ts

@@ -42,11 +42,11 @@ export class NestLandProvider extends Provider {
   }
 
   getRepositoryUrl(name: string): string {
-    return new URL(`${this.moduleName ?? name}/`, this.repositoryUrl).href;
+    return new URL(`${this.moduleName ?? name}`, this.repositoryUrl).href;
   }
 
   getRegistryUrl(name: string, version: string): string {
-    return new URL(`${this.moduleName ?? name}@${version}/`, this.registryUrl)
+    return new URL(`${this.moduleName ?? name}@${version}`, this.registryUrl)
       .href;
   }
 }

command/upgrade/provider/npm.ts

@@ -11,7 +11,8 @@ export type NpmProviderOptions =
 
 export class NpmProvider extends Provider {
   name = "npm";
-  private readonly repositoryUrl = "https://registry.npmjs.org/";
+  private readonly repositoryUrl = "https://npmjs.org/";
+  private readonly apiUrl = "https://registry.npmjs.org/";
   private readonly packageName?: string;
   private readonly packageScope: string;
 
@@ -29,7 +30,7 @@ export class NpmProvider extends Provider {
     name: string,
   ): Promise<Versions> {
     const response = await fetch(
-      `${this.repositoryUrl}/@${this.packageScope}/${this.packageName ?? name}`,
+      `${this.apiUrl}/@${this.packageScope}/${this.packageName ?? name}`,
     );
     if (!response.ok) {
       throw new Error(
@@ -46,9 +47,11 @@ export class NpmProvider extends Provider {
     };
   }
 
-  getRepositoryUrl(name: string): string {
+  getRepositoryUrl(name: string, version?: string): string {
     return new URL(
-      `@${this.packageScope}/${this.packageName ?? name}`,
+      `package/@${this.packageScope}/${this.packageName ?? name}${
+        version ? `/v/${version}` : ""
+      }`,
       this.repositoryUrl,
     ).href;
   }

command/upgrade/runtime.ts

@@ -18,5 +18,5 @@ export interface UpgradePackageOptions extends RuntimeUpgradeOptions {
 
 /** Runtime handler. */
 export abstract class Runtime {
-  abstract upgrade(_options: UpgradePackageOptions): Promise<string | null>;
+  abstract upgrade(_options: UpgradePackageOptions): Promise<void>;
 }

command/upgrade/runtime/bun_runtime.ts

@@ -7,7 +7,7 @@ export class BunRuntime extends NodeRuntime {
     cmdArgs: string[],
     isJsr: boolean,
     logger?: Logger,
-  ): Promise<string | null> {
+  ): Promise<void> {
     // deno-lint-ignore no-explicit-any
     const Bun = (globalThis as any).Bun;
     // deno-lint-ignore no-explicit-any
@@ -27,9 +27,8 @@ export class BunRuntime extends NodeRuntime {
     await proc.exited;
 
     if (proc.exitCode) {
-      return await new Response(proc.stderr).text();
+      const stderr = await new Response(proc.stderr).text();
+      throw new Error(stderr.trim());
     }
-
-    return null;
   }
 }

command/upgrade/runtime/deno_runtime.ts

@@ -14,10 +14,10 @@ export type DenoUpgradePackageOptions =
 
 /** Deno runtime upgrade handler. */
 export class DenoRuntime extends Runtime {
-  upgrade(
+  async upgrade(
     { provider, name, main, version, importMap, verbose, logger, args = [] }:
       DenoUpgradePackageOptions,
-  ): Promise<string | null> {
+  ): Promise<void> {
     const specifier: string = provider.getSpecifier(name, version, main);
 
     const cmdArgs = ["install", `--name=${name}`, "--global", "--force"];
@@ -37,13 +37,13 @@ export class DenoRuntime extends Runtime {
 
     cmdArgs.push(specifier);
 
-    return this.execute(cmdArgs, logger);
+    await this.execute(cmdArgs, logger);
   }
 
   protected async execute(
     cmdArgs: string[],
     logger?: Logger,
-  ): Promise<string | null> {
+  ): Promise<void> {
     logger?.log(
       dim("$ %s %s"),
       Deno.execPath(),
@@ -58,9 +58,7 @@ export class DenoRuntime extends Runtime {
     const { success, stderr } = await cmd.output();
 
     if (!success) {
-      return new TextDecoder().decode(stderr);
+      throw new Error(new TextDecoder().decode(stderr).trim());
     }
-
-    return null;
   }
 }

command/upgrade/runtime/node_runtime.ts

@@ -13,7 +13,7 @@ export class NodeRuntime implements Runtime {
       logger,
       args = [],
     }: UpgradePackageOptions,
-  ): Promise<string | null> {
+  ): Promise<void> {
     const specifier = provider.getSpecifier(name, version, main)
       .replace(/^(npm|jsr):/, "");
     const isJsr = provider.name === "jsr";
@@ -37,7 +37,7 @@ export class NodeRuntime implements Runtime {
     cmdArgs: string[],
     isJsr: boolean,
     logger?: Logger,
-  ): Promise<string | null> {
+  ): Promise<void> {
     const { spawn } = await import("node:child_process");
 
     const [bin, args] = isJsr ? ["npx", ["jsr", ...cmdArgs]] : ["npm", cmdArgs];
@@ -59,9 +59,7 @@ export class NodeRuntime implements Runtime {
     );
 
     if (exitCode) {
-      return stderr.join("\n");
+      throw new Error(stderr.join("\n").trim());
     }
-
-    return null;
   }
 }

command/upgrade/upgrade.ts

@@ -57,27 +57,26 @@ export async function upgrade(
     const { runtimeName, runtime } = await getRuntime();
     logger?.log(dim("Detected runtime: %s"), runtimeName);
 
-    const errorMessage: string | null = await runtime.upgrade({
-      args,
-      ...(runtimeOptions?.[runtimeName] ?? {}),
-      name,
-      version,
-      main,
-      provider,
-      logger,
-      verbose,
-    });
-
-    if (errorMessage) {
+    try {
+      await runtime.upgrade({
+        args,
+        ...(runtimeOptions?.[runtimeName] ?? {}),
+        name,
+        version,
+        main,
+        provider,
+        logger,
+        verbose,
+      });
+    } catch (error: unknown) {
       logger?.error(
         red(
           `Failed to upgrade ${bold(name)} ${
             currentVersion ? `from version ${bold(currentVersion)} ` : ""
-          }to ${bold(version)}:`,
+          }to ${bold(version)}.`,
         ),
       );
-      logger?.error(errorMessage);
-      Deno.exit(1);
+      throw error;
     }
 
     logger?.info(
@@ -86,7 +85,7 @@ export async function upgrade(
           bold(currentVersion ?? "")
         } to ${bold(version)}!`,
       ),
-      dim(`(${provider.getRegistryUrl(name, version)})`),
+      dim(`(${provider.getRepositoryUrl(name, version)})`),
     );
   }
 }

command/upgrade/upgrade_command.ts

@@ -97,6 +97,12 @@ export class UpgradeCommand extends Command {
             logger,
             ...options,
           });
+        } catch (error: unknown) {
+          logger.error(
+            !verbose && error instanceof Error ? error.message : error,
+          );
+          spinner.stop();
+          Deno.exit(1);
         } finally {
           spinner.stop();
         }