Merge pull request #107 from morozov/issue-106

Return FALSE in case of invalid arguments passed to a command

Author: c9s

.gitignore

@@ -1,6 +1,7 @@
+.hhconfig
+.onion
+build/
 composer.lock
-vendor/
 src/PHPBrew/
-build/
-.onion
-.hhconfig
+vendor/
+tmp/

composer.json

@@ -22,7 +22,8 @@
     },
     "require-dev": {
         "corneltek/phpunit-testmore": "dev-master",
-        "satooshi/php-coveralls": "^1"
+        "satooshi/php-coveralls": "^1",
+        "phpunit/phpunit": "^5.7"
     },
     "license": "MIT",
     "authors": [

src/Application.php

@@ -407,7 +407,8 @@ public function run(Array $argv)
         }
         $currentCmd->finish();
         $this->finish();
-        return true;
+
+        return $return !== false;
     }
 
     /**

src/CommandBase.php

@@ -814,7 +814,8 @@ public function executeWrapper(array $args)
 
                 if ($valid === FALSE) {
                     $this->logger->error($message ?: "Invalid argument $arg");
-                    return;
+
+                    return false;
                 }
             }
         }