Return FALSE in case of invalid arguments passed to a command #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands still can return any values or not return anything. Only explicitly returned FALSE will be interpreted as an error. Fixes #106.
|
Conflict |
|
The commit is made on top of df9139a. Once re-targeted against |
|
Ok i will do this today
Sergei Morozov <[email protected]>於 2017年11月7日 週二，09:19寫道：
… The commit is made on top of df9139a
<df9139a>.
Once rebased on 3.0, there won't be a conflict.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#107 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADGzvRcrCiWoLKea0WTqWId6uS1_mevks5sz7AfgaJpZM4QSfR9>
.
|
|
Branch 3.0 is now created |
|
Thanks @c9s! No more conflicts. |
|
Merged thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands still can return any values or not return anything. Only explicitly returned
FALSEwill be interpreted as an error.Fixes #106.